[Az.ServiceFabric] Added preannoucement for removing Reimage parameters from Set-AzServiceFabricManagedNodeType
#28520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs from `Set-AzServiceFabricManagedNodeType`
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds deprecation warnings for Reimage-related parameters in the Set-AzServiceFabricManagedNodeType cmdlet in preparation for their removal. The parameters will be deprecated in favor of a new dedicated cmdlet Invoke-AzServiceFabricReimageManagedNodeType.
Key Changes
- Added deprecation attributes to four Reimage-related parameters (NodeName, Reimage, ForceReimage, PassThru)
- Reorganized using statements and moved AsJob parameter to a different section
- Updated changelog to document the deprecation announcement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SetAzServiceFabricManagedNodeType.cs | Added deprecation attributes for Reimage parameters and reorganized code structure |
| ChangeLog.md | Added entry documenting the deprecation preannouncement |
Comments suppressed due to low confidence (1)
src/ServiceFabric/ServiceFabric/Commands/ManagedClusters/NodeTypes/SetAzServiceFabricManagedNodeType.cs:1
- There's a spelling error: 'preannoucement' should be 'preannouncement' (missing 'n').
// ----------------------------------------------------------------------------------
iliu816
commented
Sep 5, 2025
...Fabric/ServiceFabric/Commands/ManagedClusters/NodeTypes/SetAzServiceFabricManagedNodeType.cs
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
a-santamaria
reviewed
Sep 8, 2025
...Fabric/ServiceFabric/Commands/ManagedClusters/NodeTypes/SetAzServiceFabricManagedNodeType.cs
Show resolved
Hide resolved
...Fabric/ServiceFabric/Commands/ManagedClusters/NodeTypes/SetAzServiceFabricManagedNodeType.cs
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
a-santamaria
approved these changes
Sep 10, 2025
Collaborator
|
/azp run azure-powershell - security-tools |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
VeryEarly
requested changes
Sep 10, 2025
Collaborator
VeryEarly
left a comment
VeryEarly
left a comment
There was a problem hiding this comment.
next Az version: 15.0.0
next Az.ServiceFabric version: 5.0.0
…16/azure-powershell into user/iliu/deprecateReimage
Member
Author
Hi, should be changed now. Thanks |
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
VeryEarly
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because we are introducing a new
Invoke-AzServiceFabricReimageManagedNodeTypecmdlet, we want to deprecate the Reimage parameters from theSet-AzServiceFabricManagedNodeTypecmdlet.Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.