Skip to content

Conversation

@ookoka
Copy link
Member

@ookoka ookoka commented Oct 21, 2025

Added -EnableAutomaticUpgrade and -TreatFailureAsDeploymentFailure to New-AzVmGalleryApplication as well as New Az-VmssGalleryApplication cmdlts

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@ookoka ookoka force-pushed the ookoka/enable-auto-upgrade branch from 582807f to 1ef67da Compare November 4, 2025 17:57
@ookoka ookoka marked this pull request as ready for review November 4, 2025 18:03
Copilot AI review requested due to automatic review settings November 4, 2025 18:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for two new boolean flags (EnableAutomaticUpgrade and TreatFailureAsDeploymentFailure) to Gallery Application cmdlets for both Virtual Machines and Virtual Machine Scale Sets. These flags control automatic updates and deployment failure handling for gallery applications.

  • Added EnableAutomaticUpgrade and TreatFailureAsDeploymentFailure as boolean parameters to New-AzVmGalleryApplication and New-AzVmssGalleryApplication cmdlets
  • Added the same flags as switch parameters to Add-AzVmGalleryApplication and Add-AzVmssGalleryApplication cmdlets
  • Comprehensive test coverage for both VM and VMSS scenarios with multiple test cases

Reviewed Changes

Copilot reviewed 7 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
NewAzureVmGalleryApplicationCommand.cs Added two new boolean parameters for enabling automatic upgrades and treating failures as deployment failures
NewAzureVmssGalleryApplicationCommand.cs Added the same two boolean parameters for VMSS gallery applications
AddAzureVmGalleryApplicationCommand.cs Added switch parameters for the two flags with logic to set them when present
AddAzureVmssGalleryApplicationCommand.cs Added switch parameters for the two flags with logic to set them when present
New-AzVmGalleryApplication.md Updated help documentation with parameter descriptions and usage examples
New-AzVmssGalleryApplication.md Updated help documentation with parameter descriptions and usage examples
ChangeLog.md Documented the new parameters for both cmdlet types
VirtualMachineTests.ps1 Added comprehensive test for the new flags with multiple scenarios
VirtualMachineTests.cs Added test method registration
VirtualMachineScaleSetTests.ps1 Added comprehensive test for VMSS gallery application flags
VirtualMachineScaleSetTests.cs Added test method registration

@dolauli dolauli self-assigned this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants