Skip to content

Conversation

svishnusivasai
Copy link

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

S Vishnu Sanagapalli added 6 commits September 15, 2025 17:59
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2025-02-01 to stable/2025-08-01.
Copy link

github-actions bot commented Sep 17, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 17, 2025
Copy link

github-actions bot commented Sep 17, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.RecoveryServices
Go sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery
Java com.azure.resourcemanager:azure-resourcemanager-recoveryservicessiterecovery
C# Azure.ResourceManager.RecoveryServicesSiteRecovery
JavaScript @azure/arm-recoveryservices-siterecovery

@sandipsh
Copy link
Contributor

please address lintdiff and swagger validation errors.

@sandipsh sandipsh added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 23, 2025
@shrauta-ms
Copy link
Member

          "$ref": "#/definitions/UpdateMobilityServiceRequest"

change this to ReinstallMobilityServiceRequest


Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2025-08-01/service.json:4668 in 447c437. [](commit_id = 447c437, deletion_comment = False)

@shrauta-ms
Copy link
Member

        "$ref": "./examples/ReplicationProtectedItems_UpdateMobilityService.json"

change this to ReplicationProtectedItems_ReinstallMobilityService.json and give the example of the response


Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2025-08-01/service.json:4694 in 447c437. [](commit_id = 447c437, deletion_comment = False)

@shrauta-ms
Copy link
Member

      "description": "The properties of the reinstall mobility service request"

nit add a . in the end


Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2025-08-01/service.json:24125 in 447c437. [](commit_id = 447c437, deletion_comment = False)

@shrauta-ms
Copy link
Member

      "description": "Distro name for which agent is installed.",

The agent os name last agent reinstall was attempted.


Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2025-08-01/service.json:10958 in 447c437. [](commit_id = 447c437, deletion_comment = False)

@svishnusivasai
Copy link
Author

Please wait for merging this pull request as service deployment is currently in progress

@josefree
Copy link
Member

The service is under folder structure migration. The PR should proceed with new folder structure. Please contact [email protected] for any inquiries. When you reach out, ensure to bring the pull request you want to make progress.

@josefree
Copy link
Member

The service is under folder structure migration. The PR should proceed with new folder structure. Please contact [email protected] for any inquiries. When you reach out, ensure to bring the pull request you want to make progress.

The folder structure v2 can be referred here https://github.com/Azure/azure-rest-api-specs/wiki/Azure-Service-Versioning-Guideline

@svishnusivasai
Copy link
Author

Please ignore this PR and review this PR for changes adhering new folder structure: #37809

@svishnusivasai svishnusivasai deleted the users/ssanagapalli/srsApiSpec branch September 29, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version Recovery Services Site-Recovery resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants