Skip to content

Update UDR config properties for Microsoft.Network #37789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2025
Merged

Update UDR config properties for Microsoft.Network #37789

merged 3 commits into from
Oct 2, 2025

Conversation

camnic
Copy link
Contributor

@camnic camnic commented Sep 26, 2025 •
edited
Loading

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2025 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@camnic
Copy link
Contributor Author

camnic commented Sep 26, 2025

@camnic please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@camnic camnic closed this Sep 26, 2025
@camnic camnic reopened this Sep 26, 2025
@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 26, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/network/armnetwork
Java com.azure.resourcemanager:azure-resourcemanager-network-generated
JavaScript @azure/arm-network
C# Azure.ResourceManager.Network

@camnic camnic force-pushed the camenichols/avnm-udr-update branch from 5a7a8c1 to 8068d8f Compare September 26, 2025 18:10
@sandipsh sandipsh added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 26, 2025
@camnic camnic requested a review from sandipsh September 29, 2025 16:31
@github-actions github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 29, 2025
ravimeda
ravimeda approved these changes Oct 2, 2025
View reviewed changes
Copy link

@ravimeda ravimeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ravimeda ravimeda added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 2, 2025
@camnic camnic merged commit d3a4a2b into Azure:kamboj-prjwl/release-network-2025-01-01 Oct 2, 2025
64 checks passed
@camnic camnic deleted the camenichols/avnm-udr-update branch October 2, 2025 21:08
@kamboj-prjwl kamboj-prjwl mentioned this pull request Oct 8, 2025
Merged
9 tasks
kamboj-prjwl added a commit that referenced this pull request Oct 9, 2025
@kamboj-prjwl @wxy5
@brandonv191 @sbhosalemsft @EugenioPena @Nilambari @camnic @akshimittal1310
Release Microsoft.Network 2025-01-01 (#37918)
c712a51 
* Copy files from stable/2024-10-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2025-01-01

Updated the API version from stable/2024-10-01 to stable/2025-01-01.

* Added tag for 2025-01-01 in readme file

* Add suppression and directive from previous release

* Lawrencewang/pls new access mode swagger change2 (#37343)

* Added access mode for PrivateLinkService

---------

Co-authored-by: Lawrence Wang <[email protected]>

* Add support for certificate based authentication connection(#37176)

* Add support for certificate based authentication connection

* Add descriptions for connection type enums

* Add zones property to virtual network gateway

* remove minitem as it is failing ut (#37356)

Co-authored-by: Prajjwal Kamboj <[email protected]>

* Scope and default outbound access (#37577)

* Update DefaultOutboundAccess property description on virtualNetwork and add Scope to loadBalancer

* Examples

* Fix documentation generation blocking in VirtualWan.json (#37896)

* Update UDR config properties for Microsoft.Network (#37789)

* update

* add default and enum item descriptions

* resolve prettiercheck

---------

Co-authored-by: Cameron Nichols <[email protected]>

* added new feature properties (#37340)

Co-authored-by: Prajjwal Kamboj <[email protected]>

---------

Co-authored-by: Prajjwal Kamboj <[email protected]>
Co-authored-by: Lawrence Wang <[email protected]>
Co-authored-by: Lawrence Wang <[email protected]>
Co-authored-by: brandonv191 <[email protected]>
Co-authored-by: sbhosalemsft <[email protected]>
Co-authored-by: Eugenio Peña García <[email protected]>
Co-authored-by: Nilambari <[email protected]>
Co-authored-by: camnic <[email protected]>
Co-authored-by: Cameron Nichols <[email protected]>
Co-authored-by: akshimittal1310 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravimeda ravimeda ravimeda approved these changes

@kamboj-prjwl kamboj-prjwl Awaiting requested review from kamboj-prjwl

@sandipsh sandipsh Awaiting requested review from sandipsh

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Network resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camnic @ravimeda @sandipsh