-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Review request for Microsoft.ContainerService/aks to add version preview/2025-08-02-preview #37803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Review request for Microsoft.ContainerService/aks to add version preview/2025-08-02-preview #37803
Conversation
…eview/2025-07-02-preview to version preview/2025-08-02-preview
Signed-off-by: Mateusz Gozdek <[email protected]>
* Added changes for Istio CNI to 2028-08-02-preview API * run prettierc --------- Co-authored-by: German Robayo Paz <[email protected]>
Co-authored-by: indusridhar <[email protected]>
* Add MeshMembership subresource and examples * There are no async operations for PUT and DELETE so no need to mark them as long running operation * Linting * Sync deletion should return 200 and 204 --------- Co-authored-by: Zhewei Hu <[email protected]>
* Make MeshMembership PUT/DELETE long running operation * Add provisionState --------- Co-authored-by: Zhewei Hu <[email protected]>
Co-authored-by: Xintian Yang <[email protected]>
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Regarding the breaking change, compared with previous stable API version ![]()
|
Suggest using v6 #Resolved Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-08-02-preview/managedClusters.json:46 in 356f5f9. [](commit_id = 356f5f9, deletion_comment = False) |
Thanks for the summary. This helps. In reply to: 3344457468 |
Curious to know the positioning of the new one. Are the values sorted in some order? #Resolved Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-08-02-preview/managedClusters.json:8897 in 356f5f9. [](commit_id = 356f5f9, deletion_comment = False) |
nit - Create an aka.ms link that you can update as needed. #Resolved Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-08-02-preview/managedClusters.json:8974 in 356f5f9. [](commit_id = 356f5f9, deletion_comment = False) |
The article has no mention of Entra. Please add a link to appropriate doc. #Resolved Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-08-02-preview/managedClusters.json:9821 in 356f5f9. [](commit_id = 356f5f9, deletion_comment = False) |
If you have plans to update the current doc, then you can leave the link as-is. In reply to: 3365492539 Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-08-02-preview/managedClusters.json:9821 in 356f5f9. [](commit_id = 356f5f9, deletion_comment = False) |
Suggest - 'create' #Resolved Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-08-02-preview/managedClusters.json:11551 in 356f5f9. [](commit_id = 356f5f9, deletion_comment = False) |
Two letter acronyms are in uppercase. For three or more only the first letter is upper cased e.g., Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-08-02-preview/managedClusters.json:11550 in 356f5f9. [](commit_id = 356f5f9, deletion_comment = False) |
Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-08-02-preview/managedClusters.json:12434 in 356f5f9. [](commit_id = 356f5f9, deletion_comment = False) |
Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-08-02-preview/managedClusters.json:12837 in 356f5f9. [](commit_id = 356f5f9, deletion_comment = False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
Thanks for the suggestion, we are on a very tight schedule and will switch to v6 from the next monthly stable/preview API version.
Yes, that's expected. The change was made in #b1a21f6. The custom CA trust feature reached GA and has been available in the stable API version since 2025-01-01, as noted in commit #cea24e7 in PR #32934. In the stable API version, the field enableCustomCATrust is not present and has also been deprecated in the preview API version. Therefore, it's being removed starting from this preview API version.
emm, I guess they are not sorted, let me fix this.
Make sense. We'll apply this approach moving forward. For this specific description that's been around for four years, it may take some time to identify the appropriate owner first. We'll fix the issue in next preview API version. |
The sorting issue and the ETag case issue have been resolved in #db0e847. |
@ravimeda is this documented someplace -- can you share it? It doesn't match current AKS patterns and also requires RP code-change as our enums are case-sensitive (to avoid having to normalize). I think we would prefer to stick with our current pattern See for example:
Note that some enums aren't UpperCamelCase (legacy). We review for that now but didn't in the past so a few are Given we have an existing pattern I would rather stay self-consistent than break our self-consistency to follow the external rule (assuming there is one). |
The actual field is Certainly when saying "The eTag value will change...." we're literally saying "the field eTag will change". There is no "ETag" field. |
The default is dynamic, depends on the contents of the istio revisions list. Currently, it is |
Co-authored-by: German Robayo Paz <[email protected]>
yes, we will update the entra id ssh doc with this link, so just keep it. |
The default value should be |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.