Dev/communication/10 dl cv9 #36033
Draft
Dev/communication/10 dl cv9 #36033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 24, 2025 20:20
sofiar-msft
requested review from
a team,
akania,
bterlson,
chenkennt,
deyaaeldeen,
jeremymeng,
vicancy,
xirzec and
zackliu
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Azure Communication Services client library for 10DLC (10-digit long code) administration. The 10DLC program enables A2P SMS messaging for local US numbers through mobile carriers.
Key changes:
- Complete new SDK structure with client implementation, generated code, tests, and samples
- Support for managing US brands and campaigns including CRUD operations
- Cost listing functionality and campaign attachment management
- Comprehensive test suite with recorded client testing infrastructure
Reviewed Changes
Copilot reviewed 44 out of 61 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/communication/communication-ten-dlc/src/ | Core client implementation with TenDlcClient class and models |
| sdk/communication/communication-ten-dlc/test/ | Complete test suite with unit and integration tests |
| sdk/communication/communication-ten-dlc/swagger/ | Swagger specification and autorest configuration |
| sdk/communication/communication-ten-dlc/package.json | Package configuration with dependencies and build scripts |
| rush.json | Added new package to monorepo configuration |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
sdk/communication/communication-ten-dlc/test/public/campaigns.spec.ts:1
- Duplicate word 'with' in the test description. Should be 'successfully instantiates with endpoint and access key'.
// Copyright (c) Microsoft Corporation.
sdk/communication/communication-ten-dlc/test/public/brands.spec.ts:1
- Duplicate word 'with' in the test description. Should be 'successfully instantiates with endpoint and access key'.
// Copyright (c) Microsoft Corporation.
sdk/communication/communication-ten-dlc/test/utils/recordedClient.ts
Outdated
Show resolved
Hide resolved
… dev/communication/10DLCv9
…ent.ts Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…azure-sdk-for-js into dev/communication/10DLCv9
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
…recated files - Updated import statements in `brands.spec.ts`, `campaigns.spec.ts`, `costs.spec.ts`, and `ctor.spec.ts` to use the new package path `@azure-tools/communication-ten-dlc`. - Deleted obsolete test files: `campaigns.spec.js`, `costs.spec.js`, `ctor.spec.js`, `helpers.js`, `mockHttpClients.js`, `msUserAgentPolicy.js`, and `recordedClient.js`. - Refactored `recordedClient.js` to `recordedClient.ts` with updated imports and type definitions. - Ensured all tests are aligned with the new structure and imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists