DNSResolver SDK generated from TypeSpec #52217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <param name="provisioningState"> The current provisioning state of the forwarding rule. This is a read-only property and any attempt to set this value will be ignored. </param> | ||
| /// <returns> A new <see cref="DnsResolver.DnsForwardingRuleData"/> instance for mocking. </returns> | ||
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public static DnsForwardingRuleData DnsForwardingRuleData(ResourceIdentifier id, string name, ResourceType resourceType, SystemData systemData, ETag? etag, string domainName, IEnumerable<TargetDnsServer> targetDnsServers, IDictionary<string, string> metadata, DnsForwardingRuleState? dnsForwardingRuleState, DnsResolverProvisioningState? provisioningState) |
There was a problem hiding this comment.
we should not make all parameters to required.
We only make those parameters that shared with the other generated overload to required, others must remain optional
For instance,
previously we have: Foo(a = null, b = null, c = null, d = null)
now we have: Foo(a = null, b = null, d = null, c = null)
and now we must add back this:
Foo(a, b, d = null, c = null)
because a, b are shared parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
Pay attention: