Skip to content

Conversation

HarveyLink
Copy link
Member

@HarveyLink HarveyLink commented Aug 25, 2025

This is the SDK validation for Advisor.
TSP link: Azure/azure-rest-api-specs#34319

Add following rename polish to the client.tsp

@@clientName(PredictionResponse, "AdvisorPredictionResult", "csharp");
@@clientName(TriageResource, "AdvisorTriageResourceData", "csharp");
@@clientName(TriageResourceCollection,
  "AdvisorTriageResourceDataList",
  "csharp"
);
@@clientName(AssessmentResult, "AdvisorAssessmentResult", "csharp");
@@clientName(ResiliencyReview, "AdvisorResiliencyReview", "csharp");
@@clientName(ResiliencyReviewCollection,
  "AdvisorResiliencyReviewList",
  "csharp"
);
@@clientName(Control, "RecommendationControlType", "csharp");
@@clientName(Duration, "MinimumDuration", "csharp");
@@clientName(OperationEntity, "AdvisorOperationEntity", "csharp");
@@clientName(OperationDisplayInfo, "AdvisorOperationDisplayInfo", "csharp");
@@clientName(Category, "RecommendationCategory", "csharp");
@@clientName(Impact, "RecommendationBusinessImpact", "csharp");
@@clientName(PredictionResponseProperties.lastUpdated,
  "LastUpdatedOn",
  "csharp"
);
@@clientName(Priority, "RecommendationPriority", "csharp");
@@clientName(PriorityName, "RecommendationPriorityName", "csharp");
@@clientName(Reason, "RecommendationStateChangeReason", "csharp");
@@clientName(RecommendationPropertiesResourceWorkload,
  "RecommendationResourceWorkload",
  "csharp"
);
@@clientName(RecommendationPropertiesReview, "RecommendationReview", "csharp");
@@clientName(RecommendationProperties.tracked, "IsTracked", "csharp");
@@clientName(Aggregated, "ScoreAggregationLevel", "csharp");
@@clientName(ReviewStatus, "ResiliencyReviewStatus", "csharp");
@@clientName(ScoreEntity, "AdvisorScoreEntityContent", "csharp");
@@clientName(State, "RecommendationState", "csharp");
@@clientName(WorkloadResult, "AdvisorWorkloadResult", "csharp");

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Aug 25, 2025
Copy link

github-actions bot commented Aug 27, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.Advisor

@HarveyLink HarveyLink marked this pull request as ready for review August 27, 2025 23:58
@Copilot Copilot AI review requested due to automatic review settings August 27, 2025 23:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the initial SDK generation for the Azure Advisor TypeSpec specification, implementing client name mappings and renaming conventions to align with C# naming standards. The changes establish the foundation for the Advisor SDK by applying TypeSpec decorators to rename various models and properties for better C# developer experience.

  • Updates assets.json to reference new generated artifacts from TypeSpec compilation
  • Implements comprehensive client name mappings for Advisor models following C# conventions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants