Skip to content

Conversation

amarjeetkr
Copy link
Member

Contributing to the Azure SDK

Published the stable API version 2025-06-30 for DMS APIs.
Added Retry API for Database Migration.
Introduced Delete API for SQL Database Migration.
Introduced Delete API for SQL VM Migration.

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 20:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR publishes a stable API version 2025-06-30 for Azure Data Migration Service (DMS) APIs, transitioning from beta to stable release. The changes introduce new API operations for database migration management and add support for deletion and retry operations.

Key changes:

  • Release of stable version 1.0.0 for API version 2025-06-30
  • Added three new operations: Retry API for Database Migration, Delete API for SQL Database Migration, and Delete API for SQL VM Migration
  • Introduction of new project configuration for SQL Migration Management Client

Reviewed Changes

Copilot reviewed 2 out of 21 changed files in this pull request and generated no comments.

File Description
CHANGELOG.md Documents the stable release 1.0.0 with new API operations and version support
SqlMigrationManagementClient.csproj New project file configuration for SQL Migration Management Client with dependencies

@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Aug 25, 2025
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've added code to the root of the repository rather than your /sdk directory. Please revert.

@amarjeetkr amarjeetkr closed this Sep 1, 2025
@amarjeetkr amarjeetkr force-pushed the amakum/stable-dmsapi-sdk-upgrade branch from a1d3fa2 to 9d40a3e Compare September 1, 2025 19:16
@amarjeetkr amarjeetkr reopened this Sep 1, 2025
@amarjeetkr
Copy link
Member Author

@jsquire
Thank you so much for reviewing the PR.
I have resolved your comment. Could you please check it again?

@amarjeetkr amarjeetkr requested a review from jsquire September 2, 2025 11:10
@jsquire jsquire dismissed their stale review September 2, 2025 15:56

Confirmed that non-library files have been revereted.

@amarjeetkr
Copy link
Member Author

@ArthurMa1978
Coud you pelase review the PR and provide the approval on this PR if it looks good?

Copy link
Member

@ArthurMa1978 ArthurMa1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the code changes weren’t generated from the spec, as there’s no update to the autorest.md file indicating a new spec version. Since the mgmt. plane SDK is generated from the Swagger spec, please follow the doc to update the SDK accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants