Skip to content

Conversation

sophia-ramsey
Copy link
Member

@sophia-ramsey sophia-ramsey commented Aug 25, 2025

  • includes test framework for recordings for SCM, using a wrapper on Azure.Core test tools
    • the framework is not super sophisticated, so I will re-record with all tests once the new SCM test framework is released (currently skips recordings for Agents, Datasets, and Inference due to using non SCM methods)
    • includes custom sanitizers file for test recordings
  • includes assets.json tag for recordings of Connections, Deployments, Indexes, and Telemetry
  • includes test files for Agents, Azure OpenAI Inference, Connections, Datasets, Deployments, Indexes, and Telemetry

@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 23:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive test framework for Azure.AI.Projects that enables recorded testing using System.ClientModel alongside Azure.Core test infrastructure. The implementation provides test coverage across all major SDK operations while establishing proper sanitization for sensitive data in recordings.

Key changes:

  • Custom test framework bridging System.ClientModel with Azure.Core test proxies for recording/playback
  • Comprehensive sanitization patterns for Azure resource identifiers, API keys, and sensitive data
  • Test files covering Agents, Azure OpenAI Inference, Connections, Datasets, Deployments, Indexes, and Telemetry operations

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
RecordedProjectsTestBase.cs Base class providing System.ClientModel recording capabilities with transport configuration
ProjectsTestSanitizers.cs Centralized sanitization patterns for protecting sensitive data in test recordings
ProjectsProxyTransport.cs Transport adapter bridging System.ClientModel with Azure.Core test proxy infrastructure
TestClientRetryPolicy.cs Custom retry policy for fast test playback with configurable delays
TestBase.cs Main test base class with validation helpers and test parameter definitions
ProjectsClientTestBase.cs Client-specific test base providing recorded test capabilities
Various test files Individual test implementations for different SDK operations
API surface changes Methods marked as virtual to support test instrumentation
assets.json Updated tag for test recordings

Copy link

github-actions bot commented Aug 25, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.AI.Projects

@sophia-ramsey sophia-ramsey merged commit ef7b4d8 into main Aug 28, 2025
17 checks passed
@sophia-ramsey sophia-ramsey deleted the sramsey/projects-tests-recordings branch August 28, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants