Skip to content

Conversation

HarveyLink
Copy link
Member

@HarveyLink HarveyLink commented Aug 26, 2025

Generated the code from swagger based on PR: Azure/azure-rest-api-specs#35228

Need to
Remove in directive

   - rename-model:
       from: SharedPrivateLinkResource
       to: WebPubSubSharedPrivateLink
   - rename-model:
       from: WebPubSubResource
       to: WebPubSub

Add to rename-mapping

  WebPubSubResource: WebPubSub
  SharedPrivateLinkResource: WebPubSubSharedPrivateLink

Otherwise we'll get code gen error like:

error   | InvalidRef | Ref '#/definitions/WebPubSubResource' is not referencing a valid location. paths,/subscriptions/{subscriptionId}/resourceGroups/{resourc
  eGroupName}/providers/Microsoft.SignalRService/webPubSub/{resourceName},put

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Aug 26, 2025
Copy link

github-actions bot commented Aug 26, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.WebPubSub

@HarveyLink HarveyLink marked this pull request as ready for review August 26, 2025 06:37
@Copilot Copilot AI review requested due to automatic review settings August 26, 2025 06:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure WebPubSub Resource Manager SDK to use API version 2025-01-01-preview by regenerating code from the latest swagger specification. The main purpose is to bump the API version and apply necessary configuration changes to ensure proper code generation.

Key changes include:

  • Updated swagger specification reference and API version tag
  • Moved model renaming from directive-based to rename-mapping for better code generation
  • Updated sample code to reflect new API structure

Reviewed Changes

Copilot reviewed 5 out of 150 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/webpubsub/Azure.ResourceManager.WebPubSub/src/autorest.md Updated swagger spec reference, API version tag, and moved model renaming from directives to rename-mapping
sdk/webpubsub/Azure.ResourceManager.WebPubSub/samples/Sample1_ManagingWebPubSub.md Updated sample code to use new WebPubSubNetworkAcls constructor pattern
sdk/webpubsub/Azure.ResourceManager.WebPubSub/assets.json Updated asset tag for the new version
sdk/webpubsub/Azure.ResourceManager.WebPubSub/CHANGELOG.md Added changelog entry for API version update
.vscode/cspell.json Added new dictionary words for spell checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants