-
Notifications
You must be signed in to change notification settings - Fork 5k
[WebPubSub] Bump api version to 2025-01-01-preview
#52239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Azure WebPubSub Resource Manager SDK to use API version 2025-01-01-preview
by regenerating code from the latest swagger specification. The main purpose is to bump the API version and apply necessary configuration changes to ensure proper code generation.
Key changes include:
- Updated swagger specification reference and API version tag
- Moved model renaming from directive-based to rename-mapping for better code generation
- Updated sample code to reflect new API structure
Reviewed Changes
Copilot reviewed 5 out of 150 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
sdk/webpubsub/Azure.ResourceManager.WebPubSub/src/autorest.md | Updated swagger spec reference, API version tag, and moved model renaming from directives to rename-mapping |
sdk/webpubsub/Azure.ResourceManager.WebPubSub/samples/Sample1_ManagingWebPubSub.md | Updated sample code to use new WebPubSubNetworkAcls constructor pattern |
sdk/webpubsub/Azure.ResourceManager.WebPubSub/assets.json | Updated asset tag for the new version |
sdk/webpubsub/Azure.ResourceManager.WebPubSub/CHANGELOG.md | Added changelog entry for API version update |
.vscode/cspell.json | Added new dictionary words for spell checking |
Generated the code from swagger based on PR: Azure/azure-rest-api-specs#35228
Need to
Remove in
directive
Add to
rename-mapping
Otherwise we'll get code gen error like:
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.