[AutoRelease] t2-monitor-2025-07-04-83128(can only be merged by SDK owner) #41908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds auto-generated operations, models, tests, and samples for the new Data Collection Rules, Data Collection Rule Associations, and Data Collection Endpoints APIs in the Monitor management SDK.
- Introduces sync and async client operations (
DataCollectionRulesOperations,DataCollectionRuleAssociationsOperations,DataCollectionEndpointsOperations) and updates the models/enums. - Adds generated test stubs for both sync and async operations, all marked as skipped and containing placeholder validation comments.
- Provides sample scripts for listing, getting, creating, updating, and deleting the new resources.
Reviewed Changes
Copilot reviewed 44 out of 45 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/monitor/azure-mgmt-monitor/azure/mgmt/monitor/operations/_data_collection*_operations.py | New auto-generated operation implementations for rules, associations, and endpoints (sync & async) |
| sdk/monitor/azure-mgmt-monitor/azure/mgmt/monitor/models/_monitor_management_client_enums.py and __init__.py | Expanded models and added new enums for data collection resources |
| sdk/monitor/azure-mgmt-monitor/generated_tests/test_monitor*_operations*.py | Added placeholder tests for all new operations |
| sdk/monitor/azure-mgmt-monitor/generated_samples/data_collection*.py | Sample scripts for each CRUD operation on the new resources |
Comments suppressed due to low confidence (1)
sdk/monitor/azure-mgmt-monitor/generated_tests/test_monitor_management_data_collection_rules_operations_async.py:30
- The test lacks assertions or validation logic. Add checks to verify the response content and ensure the operation behaves as expected.
# please add some check logic here by yourself
sdk/monitor/azure-mgmt-monitor/generated_samples/data_collection_rules_update.py
Show resolved
Hide resolved
sdk/monitor/azure-mgmt-monitor/generated_samples/data_collection_rules_list_by_subscription.py
Show resolved
Hide resolved
ChenxiJiang333
approved these changes
Jul 21, 2025
msyyc
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6307
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1014
BuildTargetingString
azure-mgmt-monitor
Skip.CreateApiReview