Regenerate confidential ledger from typespec #41924
Draft
+6,261
−5,652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
catalinaperalta
commented
Jul 29, 2025
| *, | ||
| collection_id: Optional[str] = None, | ||
| **kwargs: Any, | ||
| ) -> LROPoller[JSON]: | ||
| ) -> LROPoller[_models.TransactionStatus]: |
There was a problem hiding this comment.
If this signature hasnt been shipped as stable, it needs some attention, the true return type here should be LROPoller[LedgerEntry] however due to the underlying usage of the begin_wait_for_commit() method the poller seems to return transactionstatus instead
catalinaperalta
changed the title
This reverts commit 6351ead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate and update the Confidential Ledger library based on the newly migrated typespec project.