Skip to content

Made response_format option type public and update docstr #41991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2025

Conversation

howieleung
Copy link
Member

Made response_format option type public and update docstr

@Copilot Copilot AI review requested due to automatic review settings July 12, 2025 03:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the response_format option types publicly available by creating a new types/__init__.py module and updating import statements throughout the codebase. The changes also standardize the documentation format for the response_format parameter across all method signatures.

  • Creates public API for response format types through a new types module
  • Updates all imports to use the public types module instead of private _types
  • Standardizes docstring formatting for response_format parameter documentation

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/ai/azure-ai-agents/azure/ai/agents/types/init.py Creates new public types module exposing AgentsResponseFormatOption and related types
sdk/ai/azure-ai-agents/azure/ai/agents/operations/_patch.py Updates import path and standardizes response_format parameter documentation
sdk/ai/azure-ai-agents/azure/ai/agents/models/_patch.py Updates import path from private _types to public types module
sdk/ai/azure-ai-agents/azure/ai/agents/aio/operations/_patch.py Updates import path and standardizes response_format parameter documentation
sdk/ai/azure-ai-agents/azure/ai/agents/aio/_patch.py Updates import path and standardizes response_format parameter documentation
sdk/ai/azure-ai-agents/azure/ai/agents/_patch.py Updates import path and standardizes response_format parameter documentation
Comments suppressed due to low confidence (30)

sdk/ai/azure-ai-agents/azure/ai/agents/operations/_patch.py:203

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/operations/_patch.py:373

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/operations/_patch.py:518

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/operations/_patch.py:700

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/operations/_patch.py:816

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/operations/_patch.py:1003

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/operations/_patch.py:200

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/operations/_patch.py:366

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/operations/_patch.py:510

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/operations/_patch.py:688

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/operations/_patch.py:800

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/operations/_patch.py:982

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/_patch.py:148

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/_patch.py:214

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/_patch.py:306

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/_patch.py:402

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/_patch.py:468

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/_patch.py:579

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/_patch.py:743

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/_patch.py:848

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/aio/_patch.py:952

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/_patch.py:147

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/_patch.py:213

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/_patch.py:304

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/_patch.py:402

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/_patch.py:469

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/_patch.py:581

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/_patch.py:745

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/_patch.py:850

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

sdk/ai/azure-ai-agents/azure/ai/agents/_patch.py:953

  • The type reference 'agentsApiResponseFormat' uses inconsistent casing. It should be 'AgentsApiResponseFormat' to match Python naming conventions for class names.
                               ~azure.ai.agents.models.agentsApiResponseFormat]]

@howieleung howieleung merged commit 9d7aea0 into main Jul 14, 2025
19 checks passed
@howieleung howieleung deleted the howie/response-format branch July 14, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants