- 
                Notifications
    You must be signed in to change notification settings 
- Fork 318
Add JSON, XML mock perf tests for azure_core #3212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds mock JSON and XML performance tests using a mock transport to isolate and measure pipeline and (de)serialization overhead.
- Introduces perf test entry point and registers mock_json (and conditional mock_xml) tests.
- Adds mock data models and test implementations for JSON and XML formats.
- Adds pipeline configuration for running perf tests via Azure DevOps YAML definitions.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description | 
|---|---|
| sdk/core/azure_core/perf/perf.rs | Adds perf test launcher registering mock tests. | 
| sdk/core/azure_core/perf/mock/json.rs | Implements JSON mock perf test including pipeline and serialization. | 
| sdk/core/azure_core/perf/mock/xml.rs | Implements XML mock perf test (behind xml feature) mirroring JSON version. | 
| sdk/core/azure_core/perf/mock.rs | Defines shared mock list/data model types used by both tests. | 
| sdk/core/azure_core/perf.yml | Adds scheduled Azure DevOps pipeline config for perf runs. | 
| sdk/core/azure_core/perf-tests.yml | Declares perf test matrix (JSON enabled, XML commented). | 
| sdk/core/azure_core/Cargo.toml | Registers the perf harness-less test target. | 
Comments suppressed due to low confidence (1)
sdk/core/azure_core/perf/mock.rs:1
- [nitpick] These public data model types lack doc comments; add brief descriptions to clarify structure (e.g., List represents a paged container of items, ListItemProperties contains metadata like etag and timestamps) to aid reuse and future maintenance.
// Copyright (c) Microsoft Corporation. All rights reserved.
              
                    LarryOsterman
  
              
              approved these changes
              
                  
                    Oct 16, 2025 
                  
              
              
            
            
              
                    LarryOsterman
  
              
              approved these changes
              
                  
                    Oct 16, 2025 
                  
              
              
            
            
Uses a mock transport to more accurately test the pipeline and deserialization.
              
                    LarryOsterman
  
              
              approved these changes
              
                  
                    Oct 17, 2025 
                  
              
              
            
            
              
                    LarryOsterman
  
              
              approved these changes
              
                  
                    Oct 17, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uses a mock transport to more accurately test the pipeline and deserialization.