Skip to content

Conversation

@heaths
Copy link
Member

@heaths heaths commented Oct 15, 2025

Uses a mock transport to more accurately test the pipeline and deserialization.

@heaths heaths requested a review from LarryOsterman October 15, 2025 23:58
Copilot AI review requested due to automatic review settings October 15, 2025 23:58
@github-actions github-actions bot added the Azure.Core The azure_core crate label Oct 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds mock JSON and XML performance tests using a mock transport to isolate and measure pipeline and (de)serialization overhead.

  • Introduces perf test entry point and registers mock_json (and conditional mock_xml) tests.
  • Adds mock data models and test implementations for JSON and XML formats.
  • Adds pipeline configuration for running perf tests via Azure DevOps YAML definitions.

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
sdk/core/azure_core/perf/perf.rs Adds perf test launcher registering mock tests.
sdk/core/azure_core/perf/mock/json.rs Implements JSON mock perf test including pipeline and serialization.
sdk/core/azure_core/perf/mock/xml.rs Implements XML mock perf test (behind xml feature) mirroring JSON version.
sdk/core/azure_core/perf/mock.rs Defines shared mock list/data model types used by both tests.
sdk/core/azure_core/perf.yml Adds scheduled Azure DevOps pipeline config for perf runs.
sdk/core/azure_core/perf-tests.yml Declares perf test matrix (JSON enabled, XML commented).
sdk/core/azure_core/Cargo.toml Registers the perf harness-less test target.
Comments suppressed due to low confidence (1)

sdk/core/azure_core/perf/mock.rs:1

  • [nitpick] These public data model types lack doc comments; add brief descriptions to clarify structure (e.g., List represents a paged container of items, ListItemProperties contains metadata like etag and timestamps) to aid reuse and future maintenance.
// Copyright (c) Microsoft Corporation. All rights reserved.

@heaths
Copy link
Member Author

heaths commented Oct 16, 2025

See Azure/azure-sdk-for-go#25440.

@heaths heaths enabled auto-merge (squash) October 16, 2025 23:08
Uses a mock transport to more accurately test the pipeline and deserialization.
@heaths heaths merged commit 91cd633 into Azure:main Oct 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core The azure_core crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants