Add base64 tests #3220
Merged
Add base64 tests #3220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on feedback from Azure#3214
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the base64 encoding/decoding functionality in the typespec_client_core crate. The tests validate both standard and URL-safe base64 variants, including edge cases and serde integration.
Key changes:
- Added a test module with 16 test functions covering encoding, decoding, roundtrip operations, and serde integration
- Tests validate both standard and URL-safe base64 variants with optional value handling
- Includes edge case testing for empty inputs, single characters, and invalid input handling
LarryOsterman
approved these changes
Oct 17, 2025
Thought of a few other negative cases while I was at it.
LarryOsterman
approved these changes
Oct 17, 2025
LarryOsterman
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from #3214