Add tests for lro scenarios #3363
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Collaborator
|
All changed packages have been documented.
|
Collaborator
|
You can try these changes here
|
catalinaperalta
requested review from
bterlson,
iscai-msft,
jhendrixMSFT,
joheredi,
lmazuel,
m-nash,
markcowl,
srnagar,
tadelesh and
weidongxu-microsoft
as code owners
iscai-msft
reviewed
Oct 31, 2025
Contributor
iscai-msft
left a comment
iscai-msft
left a comment
There was a problem hiding this comment.
This overall looks pretty good to me, however I would reorganize. I would put all of these into one folder and main.tsp, call it azure-core/lro/lro-status, and have a namespace for cancelled, failed etc
| let uploadPollCount = 0; | ||
|
|
||
| function uploadPendingHandler(req: MockRequest) { | ||
| req.expect.containsQueryParam("api-version", "2022-12-01-preview"); |
Contributor
There was a problem hiding this comment.
depending on whether we really want to test api version, we either should remove it from this file, or explicitly state in the scenario docs that we're looking for api version of a certain value
markcowl
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some tests for scenarios that folks frequently customize in their client libraries. Eventually, client libraries should be able to customize LRO generation based on typespec definitions like custom lro status values.