Skip to content

[DO NOT MERGE] Add token revocation support for App Service #5493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

[DO NOT MERGE] Add token revocation support for App Service #5493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/Microsoft.Identity.Client/ManagedIdentity/AppServiceManagedIdentitySource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace Microsoft.Identity.Client.ManagedIdentity
internal class AppServiceManagedIdentitySource : AbstractManagedIdentity
{
// MSI Constants. Docs for MSI are available here https://docs.microsoft.com/azure/app-service/overview-managed-identity
private const string AppServiceMsiApiVersion = "2019-08-01";
private const string AppServiceMsiApiVersion = "2025-03-30";
private const string SecretHeaderName = "X-IDENTITY-HEADER";

private readonly Uri _endpoint;
Expand Down
5 changes: 3 additions & 2 deletions src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentitySourceExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ internal static class ManagedIdentitySourceExtensions
{
private static readonly HashSet<ManagedIdentitySource> s_supportsClaimsAndCaps =
[
// add other sources here as they light up
ManagedIdentitySource.ServiceFabric,
// add other sources here as they light up
ManagedIdentitySource.ServiceFabric,
ManagedIdentitySource.AppService
];

internal static bool SupportsClaimsAndCapabilities(
Expand Down
2 changes: 1 addition & 1 deletion tests/Microsoft.Identity.Test.Common/Core/Mocks/MockHttpManagerExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ private static MockHttpMessageHandler BuildMockHandlerForManagedIdentitySource(
{
case ManagedIdentitySource.AppService:
httpMessageHandler.ExpectedMethod = HttpMethod.Get;
expectedQueryParams.Add("api-version", "2019-08-01");
expectedQueryParams.Add("api-version", "2025-03-30");
expectedQueryParams.Add("resource", resource);
expectedRequestHeaders.Add("X-IDENTITY-HEADER", "secret");
break;
Expand Down
4 changes: 4 additions & 0 deletions .../Microsoft.Identity.Test.Integration.netcore/HeadlessTests/ManagedIdentityTests.NetFwk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,10 @@ public async Task AcquireMSITokenWithClaimsAsync(
// Token source should now be IdentityProvider again
Assert.AreEqual(TokenSource.IdentityProvider,
result3.AuthenticationResultMetadata.TokenSource);

// The new access token (with claims) must be different than the initial one
Assert.AreNotEqual(result1.AccessToken, result3.AccessToken,
"Claims challenge should result in a new access token different from the initial one.");
}
}

Expand Down