feat: 이벤트 알림 로직 구현 #102
Open
feat: 이벤트 알림 로직 구현 #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dh2906
approved these changes
Jan 2, 2026
Contributor
dh2906
left a comment
dh2906
left a comment
There was a problem hiding this comment.
고생하셨습니다!
메시지 알림 전송 실패 시 재시도하는 것도 있으면 좋을 듯 합니당
dh2906
reviewed
Jan 3, 2026
| @@ -0,0 +1,9 @@ | |||
| package gg.agit.konect.domain.user.event; | |||
|
|
|||
| public record UserRegisterEvent( | |||
Contributor
There was a problem hiding this comment.
이벤트는 이미 발생한 사건을 표현하므로, 네이밍은 과거형을 사용하는 것이 적절하다고 합니다!
링크
Collaborator
Author
There was a problem hiding this comment.
오 이런 네이밍 규칙이 있군요 👀
| private final SlackNotificationService slackNotificationService; | ||
|
|
||
| @Async | ||
| @TransactionalEventListener(phase = AFTER_COMMIT) |
Contributor
There was a problem hiding this comment.
단순 궁금증인데 서비스 레이어에서 트랜잭션 메소드가 커밋되고 난 뒤 이벤트를 수행하는 구조가 맞나요??? 👀
Collaborator
Author
There was a problem hiding this comment.
트랜잭션이 정상적으로 커밋이 되면 이벤트를 수행하는 구조 맞습니다
* feat: 탈퇴 회원 보관을 위한 WithdrawnUser 엔티티 및 테이블 추가 * feat: 미납 회비 탈퇴 차단 예외 코드 추가 * refactor: 회원 탈퇴 로직 개선 (미납 회비 검증 및 탈퇴 회원 아카이빙) * feat: 탈퇴 회원 1년 후 자동 삭제 배치 스케줄러 구현 * refactor: 미납 회비 검증 로직을 ClubMember 도메인 메소드로 이동 * refactor: 불필요한 WithdrawnUser 아카이브 기능 제거 * refactor: DB CASCADE 활용으로 회원 탈퇴 로직 단순화 * chore: 주석 삭제 * refactor: CASCADE로 대체된 불필요한 deleteByUserId 메소드 제거 * fix: 미납 회비 유효성 검증 메소드 네이밍 수정
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
이벤트 알림 로직 구현
💬 참고 사항
✅ Checklist (완료 조건)