-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 동아리 공부 시간 랭킹 업데이트 스케줄러 추가 #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…o feat/CAM-151-club-studytime-ranking-scheduler # Conflicts: # src/main/java/gg/agit/konect/domain/studytime/repository/StudyTimeRankingRepository.java
dh2906
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
| RankingType rankingType = rankingTypeRepository.getByNameIgnoreCase(RANKING_TYPE_CLUB); | ||
| List<StudyTimeRanking> studyTimeRankings = studyTimeRankingRepository.findByRankingTypeId(rankingType.getId()); | ||
| if (studyTimeRankings.isEmpty()) { | ||
| return ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 공백 들어가있어요!!
| private final StudyTimeSchedulerService studyTimeSchedulerService; | ||
|
|
||
| @Scheduled(fixedDelay = 5, timeUnit = MINUTES) | ||
| public void clubStudyTimeRankingUpdate() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스케줄러의 메소드 네이밍은 update가 뒤에 있는 이유가 있나요? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
큰 이유는 없었는데, 행위를 앞에 적는게 좋아보이네염
* feat: 개인 공부 시간 랭킹 업데이트 스케쥴링 추가 * feat: 학번 공부 시간 랭킹 업데이트 스케쥴링 추가 (#108) Co-authored-by: soundbar91 <[email protected]> --------- Co-authored-by: soundbar91 <[email protected]>
|
🔍 개요
🚀 주요 변경 내용
동아리 공부 시간 랭킹 업데이트 스케줄러 추가
랭킹에 등록된 동아리의 멤버 조회 -> 각 멤버의 공부시간(일간, 월간) 조회 -> 각 동아리에 소속된 멤버의 공부시간(일간, 월간) 합산 -> 동아리 공부 시간 랭킹 업데이트플로우로 진행됩니다.💬 참고 사항
✅ Checklist (완료 조건)