client: remove Docker containers named hello-world; we probably created them #6494
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Docker cleanup logic to remove containers named "hello-world" in addition to existing BOINC containers. The change adds a conditional check to identify hello-world containers and includes them in the removal process.
- Adds detection for "hello-world" containers during cleanup
- Bypasses BOINC-specific checks for hello-world containers
- Includes hello-world containers in the removal command execution
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if (retval) continue; | ||
| if (!docker_is_boinc_name(name.c_str())) continue; | ||
| if (info.container_present(name)) continue; | ||
| if (strstr(line.c_str(), "hello-world")) { |
There was a problem hiding this comment.
Using strstr() for container name matching could produce false positives. A container named 'my-hello-world-app' would match this condition. Consider using exact name matching or checking if the container name equals 'hello-world'.
| if (strstr(line.c_str(), "hello-world")) { | |
| if (name == "hello-world") { |
| if (!docker_is_boinc_name(name.c_str())) continue; | ||
| if (info.container_present(name)) continue; | ||
| if (strstr(line.c_str(), "hello-world")) { | ||
| // delete hello-world containers |
There was a problem hiding this comment.
The comment is incomplete and doesn't explain why hello-world containers should be deleted or what creates them. Consider expanding the comment to explain the rationale, such as '// Remove hello-world containers created during Docker testing/validation'.
| // delete hello-world containers | |
| // Remove hello-world containers created during Docker installation/testing. | |
| // These are not related to BOINC jobs and can be safely deleted. |
|
The created names of the hello-world containers are random picked, like this example in my containers.json: {
"id": "124dc77c41b6246f4cd0eca38a5f83d361e8bc1f80dcd4dd7f0de9969ca265d4",
"names": [
"reverent_haslett"
],
"image": "74cc54e27dc41bb10dc4b2226072d469509f2f22f1a3ce74f4a59661a1d44602",
"layer": "1abc6bec1d1a2ea977dbbb62f628d1637e69dc056f29d576a71be4c8503ebe99",
"metadata": "{\"image-name\":\"docker.io/library/hello-world:latest\",\"image-id\":\"74cc54e27dc41bb10dc4b2226072d469509f2f22f1a3ce74f4a59661a1d44602\",\"name\":\"reverent_haslett\",\"created-at\":1751120539}",
"created": "2025-06-28T14:22:19.190258588Z",
"flags": {
"MountLabel": "",
"ProcessLabel": ""
}
}So maybe check the metadata? |
|
This is not needed. Now all the created 'hello-world' containers will be automatically removed. |
|
Imho I disagree. This PR is probably not good enough, but -more generally speaking- : what is created by the client, should be deleted by the client. |
|
And this will be done with the new released version. |
|
I agree to disagree :) Is the de-installation of the client taking care of removing the boinc user and it's files? |
|
No, and this is done by intention. |
|
Ok, you can ping me for testing the cleanup. There are ~20 hello-world containers on my host now, running version |
3 participants
No description provided.