Use GLAD2 instead of GLEW #373
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should fix #372 |
blast007
reviewed
May 2, 2025
include/bzfgl.h
Outdated
| #include <GL/glu.h> | ||
|
|
||
| /* These will track glBegin/End pairs to make sure that they match */ | ||
| #ifdef DEBUG |
Member
There was a problem hiding this comment.
This block that defines glBegin and glEnd with extra validation fails to build now because GLAD already creates definitions for these. I don't know if there's a good way to retain this validation.
Contributor
Author
There was a problem hiding this comment.
I did not build debug, so I did not catch that piece of code.
To do extra validation we could use what is written in https://github.com/Dav1dde/glad/wiki/C#Debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.