Inspector V2 Physics properties #16800
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16800/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16800/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16800/merge#BCU1XR#0 |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
packages/dev/inspector-v2/src/components/properties/physicsProperties.tsx
Outdated
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/properties/physicsProperties.tsx
Outdated
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/properties/physicsProperties.tsx
Outdated
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/properties/physicsProperties.tsx
Outdated
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/properties/physicsProperties.tsx
Outdated
Show resolved
Hide resolved
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16800/merge/ |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
There was a problem hiding this comment.
Loving it, lets wait on @ryantrem and @georginahalpern for final approval
|
ahah just noticed @ryantrem finalized this one so letting @georginahalpern to review :-) |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16800/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16800/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16800/merge#BCU1XR#0 |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16800/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16800/merge/ |
packages/dev/inspector-v2/src/components/properties/physicsProperties.tsx
Show resolved
Hide resolved
|
WebGL2 visualization test reporter: |
packages/dev/inspector-v2/src/components/properties/physicsProperties.tsx
Show resolved
Hide resolved
|
Visualization tests for WebGPU |
- [x] Motion type - [x] Prestep type - [x] Mass - [x] Linear/angular damping edit - [x] Linear/angular velocity value This PR contains basic support for physics body properties (from a TransformNode.physicsBody). If there is no physicsBody, right now it just uses a placeholder line component. Later, we are thinking we can provide some info and maybe a link to docs. I (@ryantrem) also included some additional changes/fixes in this PR: - "Flatten" AccordionPane. There is really no reason at this layer to have an array of content, since the original purpose of that in the context of PropertiesPane was to make it so the delegate doesn't have to be duplicated, but at this layer there is no delegate. - Update `useProperty` to return undefined if `target` is undefined, which is more consistent with getting undefined when the property does not exist. - Update `DropdownProps.options` to be a readonly array (otherwise there is a compile error if you try to pass in a readonly array because it thinks the Dropdown needs to be able to mutate the array). - Update `Dropdown` to use `useMemo` instead of `useState` so it updates with props changes. --------- Co-authored-by: Ryan Tremblay <[email protected]>
- [x] Motion type - [x] Prestep type - [x] Mass - [x] Linear/angular damping edit - [x] Linear/angular velocity value This PR contains basic support for physics body properties (from a TransformNode.physicsBody). If there is no physicsBody, right now it just uses a placeholder line component. Later, we are thinking we can provide some info and maybe a link to docs. I (@ryantrem) also included some additional changes/fixes in this PR: - "Flatten" AccordionPane. There is really no reason at this layer to have an array of content, since the original purpose of that in the context of PropertiesPane was to make it so the delegate doesn't have to be duplicated, but at this layer there is no delegate. - Update `useProperty` to return undefined if `target` is undefined, which is more consistent with getting undefined when the property does not exist. - Update `DropdownProps.options` to be a readonly array (otherwise there is a compile error if you try to pass in a readonly array because it thinks the Dropdown needs to be able to mutate the array). - Update `Dropdown` to use `useMemo` instead of `useState` so it updates with props changes. --------- Co-authored-by: Ryan Tremblay <[email protected]>
This PR contains basic support for physics body properties (from a TransformNode.physicsBody). If there is no physicsBody, right now it just uses a placeholder line component. Later, we are thinking we can provide some info and maybe a link to docs.
I (@ryantrem) also included some additional changes/fixes in this PR:
usePropertyto return undefined iftargetis undefined, which is more consistent with getting undefined when the property does not exist.DropdownProps.optionsto be a readonly array (otherwise there is a compile error if you try to pass in a readonly array because it thinks the Dropdown needs to be able to mutate the array).Dropdownto useuseMemoinstead ofuseStateso it updates with props changes.