NavigationPluginV2 addon #17035

RolandCsibrei · 2025-08-16T22:02:34Z

Already working examples (I need to tide up the code a bit):
http://localhost:1338/#KVQP83#203 = navmesh generation stuff
http://localhost:1338/#KVQP83#209 = obstacles
http://localhost:1338/#KVQP83#213 = offmesh
http://localhost:1338/#KVQP83#245 = move along navmesh with WASD
http://localhost:1338/#KVQP83#244 = raycast

bjsplat · 2025-08-16T22:03:57Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-16T22:03:58Z

Reviewer - this PR has made changes to one or more package.json files.

RolandCsibrei · 2025-08-16T22:07:05Z

Hello!
Finally it's here :-)

I still couldn't resolve the worker issue: https://forum.babylonjs.com/t/replacing-recastjs-with-recast-navigation-js/56003/88?u=roland

At this point we support all the V1 plugin functions + offMeshConnections. These are some enhacements beyond V1:

Inject custom TileCacheMeshProcess
Support Areas, Flags (this allows to set certain polys as water, sand, etc...)
Add userId support - each agent could have an userId. Some Recast functions can treat different users differently (some users can use the teleports, some must avoid the obstacle, some mustn't, etc...)
Implement all debug layers

bjsplat · 2025-08-16T23:10:07Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-16T23:10:07Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T04:44:32Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T04:44:32Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T08:02:28Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T08:02:29Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T09:30:15Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T09:30:16Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T10:06:32Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T10:06:33Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T11:43:46Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T11:43:46Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-17T12:15:11Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-17T12:15:12Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-24T14:20:55Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-24T14:20:55Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-25T05:37:26Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-25T05:37:26Z

Reviewer - this PR has made changes to one or more package.json files.

RolandCsibrei · 2025-08-25T07:46:39Z

@ryantrem since the options parameter is for several functions the same I'll introduce a type for it

ryantrem · 2025-08-25T18:33:28Z

packages/dev/addons/src/navigation/factory/factory.worker.ts

+            navMeshQuery: NavMeshQuery;
+            tileCache?: TileCache;
+        }>((resolve, _reject) => {
+            GenerateNavMeshWithWorker(meshes, parameters, {


Seems like GenerateNavMeshWithWorker can synchronously throw, but there is no try/catch with a call to _reject. I think that should be added if I'm reading the code correctly.

Do not review the worker yet please.

ryantrem · 2025-08-25T18:36:24Z

packages/dev/addons/src/navigation/generator/generator.worker.ts

+    // callback function to process the message from the worker
+    workerOptions.worker.onmessage = (e) => {
+        if ((e as any).data?.success === false) {
+            throw new Error(`Unable to generate navMesh: ${e}`);


Where do these errors go? I assume they just show up as console errors, and the promise on the other side of this never resolves or rejects?

Do not review the worker yet please.

packages/dev/addons/src/navigation/common/getters.ts

packages/dev/addons/src/navigation/types.ts

bjsplat · 2025-08-30T07:55:48Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-30T07:55:49Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-30T07:57:42Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-30T07:57:43Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-30T09:08:44Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-30T09:08:45Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-30T09:33:14Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-30T09:33:14Z

Reviewer - this PR has made changes to one or more package.json files.

bjsplat · 2025-08-30T17:32:58Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-08-30T17:32:59Z

Reviewer - this PR has made changes to one or more package.json files.

RolandCsibrei · 2025-09-02T13:08:48Z

@deltakosh @ryantrem @CedricGuillemet
Guys, I’d like to close the PR this week if possible. I’ll be on vacation for two weeks starting this weekend. Are there any other issues you’d like me to fix or change before then?

The UMD build always fails. I believe we need to update some of the build scripts to properly handle the recast-navigation-js dev dependency during the build process. I found some code that handles similar dependencies in generateDeclaration.ts (line 166), but I’m not sure if that’s the right place to make changes.

Thank you!

ryantrem · 2025-09-02T20:28:11Z

@deltakosh @ryantrem @CedricGuillemet Guys, I’d like to close the PR this week if possible. I’ll be on vacation for two weeks starting this weekend. Are there any other issues you’d like me to fix or change before then?

The UMD build always fails. I believe we need to update some of the build scripts to properly handle the recast-navigation-js dev dependency during the build process. I found some code that handles similar dependencies in generateDeclaration.ts (line 166), but I’m not sure if that’s the right place to make changes.

Thank you!

My main outstanding questions are:

The top level API - if I'm understanding correctly, I think you've resolved this. Now you are just supposed to call functions like CreateNavigationPluginAsync and never directly instantiate the RecastNavigationJSPluginV2 class, correct? And no other setup is needed, just call one of the async factory functions and you are good to go, yes?
Back compat confusion - there are a number of open comments where you mentioned you don't want to break back compat, but these are all on completely new files/APIs, so I'm unclear what back compat means to you in the context of this PR. In my mind, back compat was limited to implementing the existing INavigationEnginePlugin interface so that anyone currently using this interface can use the v2 implementation. I don't see net new files, module level exports, classes, class members as needing any kind of back compat (since they are net new). But maybe you have something in mind that I'm not understanding.

RolandCsibrei · 2025-09-02T21:08:43Z

The top level API - if I'm understanding correctly, I think you've resolved this. Now you are just supposed to call functions like CreateNavigationPluginAsync and never directly instantiate the RecastNavigationJSPluginV2 class, correct? And no other setup is needed, just call one of the async factory functions and you are good to go, yes?

You can calll the create function or you instantiate the plugin for backwards compatibility (in PG). This is where the exported let BjsRecast variable comes in role.

Back compat confusion - there are a number of open comments where you mentioned you don't want to break back compat, but these are all on completely new files/APIs, so I'm unclear what back compat means to you in the context of this PR. In my mind, back compat was limited to implementing the existing INavigationEnginePlugin interface so that anyone currently using this interface can use the v2 implementation. I don't see net new files, module level exports, classes, class members as needing any kind of back compat (since they are net new). But maybe you have something in mind that I'm not understanding.

There are onyl two files where backwards compatility playes role: the plugin class and the crowd class

RolandCsibrei added 5 commits August 6, 2025 19:16

greasedline far positions precision loss fix

1fa1e80

Merge branch 'master' of github.com:BabylonJS/Babylon.js

f5d2ec1

First commit

ea9fa49

Correct handling of Intermediates

1e1e9f6

Added docs, tileCache support, etc.

70252be

RolandCsibrei marked this pull request as draft August 16, 2025 22:03

Removed unused class properties

7fd0f03

Formatting, refactor

e144dd1

fixed export paths

89f9a5d

fixing imports

cc76916

Backwards compatible Uint32Array handling

63a6793

updated imports

c2c2be9

updating imports

b982f14

moveAlongWithVelocity and raycast added

bd6f3df

ryantrem reviewed Aug 25, 2025

View reviewed changes

packages/dev/addons/src/navigation/common/getters.ts Outdated Show resolved Hide resolved

ryantrem reviewed Aug 25, 2025

View reviewed changes

packages/dev/addons/src/navigation/common/getters.ts Outdated Show resolved Hide resolved

ryantrem reviewed Aug 25, 2025

View reviewed changes

packages/dev/addons/src/navigation/types.ts Show resolved Hide resolved

ryantrem's reviews

65c9001

Added some comments

f1902bd

getters for crowd stuff

b96dfd1

RolandCsibrei requested a review from ryantrem August 30, 2025 09:07

fixing imports

8996fe2

import fix

2ebfa97

NavigationPluginV2 addon #17035

Are you sure you want to change the base?

NavigationPluginV2 addon #17035

Uh oh!

Conversation

RolandCsibrei commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjsplat commented Aug 16, 2025

Uh oh!

bjsplat commented Aug 16, 2025

Uh oh!

RolandCsibrei commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjsplat commented Aug 16, 2025

Uh oh!

bjsplat commented Aug 16, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 17, 2025

Uh oh!

bjsplat commented Aug 24, 2025

Uh oh!

bjsplat commented Aug 24, 2025

Uh oh!

bjsplat commented Aug 25, 2025

Uh oh!

bjsplat commented Aug 25, 2025

Uh oh!

RolandCsibrei commented Aug 25, 2025

Uh oh!

ryantrem Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

RolandCsibrei Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryantrem Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

RolandCsibrei Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bjsplat commented Aug 30, 2025

Uh oh!

bjsplat commented Aug 30, 2025

Uh oh!

bjsplat commented Aug 30, 2025

Uh oh!

bjsplat commented Aug 30, 2025

Uh oh!

bjsplat commented Aug 30, 2025

Uh oh!

RolandCsibrei commented Aug 16, 2025 •

edited

Loading

RolandCsibrei commented Aug 16, 2025 •

edited

Loading

RolandCsibrei Aug 30, 2025 •

edited

Loading

RolandCsibrei Aug 30, 2025 •

edited

Loading

RolandCsibrei commented Sep 2, 2025 •

edited

Loading