Asynchronous shader compilation #1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 24, 2023 11:21
bghgary
requested changes
Mar 3, 2023
added 2 commits
March 3, 2023 16:45
bghgary
reviewed
Mar 6, 2023
glangstonb
commented
Mar 7, 2023
bghgary
reviewed
Mar 8, 2023
bghgary
reviewed
Mar 8, 2023
bghgary
reviewed
Mar 8, 2023
bghgary
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code allows making shader compilation occur in a separate thread so that it doesn't block the Javascript thread. It's intended to be reverse-compatible with BabylonJS as of commit 52d30c49fffd2d9bd446668eb0b61337f7c167aa on master, but shaders will not compile asynchronously with that version; I will make another PR into BabylonJS with the necessary Typescript code to support asynchronous shader compilation using this code, and the shader compilation will be asynchronous only when both updates are used together.
Fixes #402
The PR for the BabylonJS side has now been opened:
BabylonJS/Babylon.js#13587