Initial preparation for Android XR support #1552
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
Hi @matthargett issue with D3D12 is fixed with #1550 |
Excellent, thanks! Once the JsRuntimeHost PR passes and merges, I'll pop back up to this one and remove the local patch. |
|
JSRuntimeHost PR is complete and awaiting review/merge. Once that's done, I'll update this PR to pull in that version and continue. BabylonJS/JsRuntimeHost#115 |
- Add `dist/` TS build folder in gitIgnore - up to latest macOS for installation test iOS/macOS - up Babylon.js to 8.28.2 - Increased Timeout to 60min because D3D12 check is way slower that it was 2weeks ago - Disabled 2 Visual Tests with D3D12 - Moved screenshot capture method from Engine to TestUtils
…JsRuntimeHost PR branch to test integration. macOS tests build and pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the first few steps toward support for Android XR devices. This should not narrow support for prior Android operating systems and devices. This adds some v8 toolchain root hints to help make sure that the Android OS-supplied v8 library is used, and not a compile of JSC.
For context, there are multiple targets we care about for shipping our existing WebXR BabylonJS app in a native container (in priority order of important to our goals/customers):
The next step will be to create a WebXR API-compatible N-API native module that can integrate with BabylonNative ether by itself, or coordinated through NativeScript. This should allow for existing BabylonJS WebXR codepaths to remain unchanged and for the JS layer to stay ignorant of the kind of JS+3D runtime container it happens to be executing in.