Workaround some lingering problems with LFortran and deploy CI #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously assertion failures on LFortran were printing garbage
LFortran generates a segfault upon first assignemnt to the allocatable array without a preceding allocation. Also, add some comments to clarify the math error in this example code is deliberate, and update the documentation to match the actual program.
Add build without assertions to ensure the code actually compiles without error, and disable the stage entirely for LFortran, which is currently unable to correctly compile this code (issue BerkeleyLab#68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GitHub-driven CI against LFortran-0.54, thanks to a docker container provided by @PHHargrove .
It also deploys workarounds for some defects in LFortran triggered by Assert library/test code.
One defect (issue #68) remains with no known workaround, so LFortran CI is disabled for that configuration.