CI: Check assertion output more rigorously, and add LFortran:latest #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend steps that run assertion failures to check not only the expected exit code, but also that the output appears to include a legible assertion message. This is intended to catch cases where the ERROR STOP character output is garbled, a defect we've now separately seen from two compilers. New CHECK_ASSERT variable factors this logic and applies it where appropriate. Force bash as the default shell, because otherwise containers default to /bin/sh
bonachea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend steps that run assertion failures to check not only the expected exit code, but also that the output appears to include a legible assertion message. This is intended to catch cases where the ERROR STOP character output is garbled, a defect we've now separately seen from two compilers.
New CHECK_ASSERT variable factors this logic and applies it where appropriate.
Also add testing of LFortran:latest using the container built from lfortran:main
Force bash as the default shell, because otherwise containers default to /bin/sh