Adding Server Groups And Removing Validating Schema Structure To Better Align With REST API Using Pedantic #689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the key
serverGroupboth on instance and configuration level. Setting a previously createdserverGroupallows users to influence whether their VMs are scheduled on the same or different hypervisors. This is helpful to spread the load of large machines. Works now both for permanent instances and on demand scheduled workers. See #688In the past BiBiGrid used schema for validation in regular use and pedantic for REST with fastapi. This PR removed the schema validation and replaced it with pedantic. This avoids having two different sources of validation truth which caused minor deviations in the past.
However, switching to pedantic also revealed a conceptual issue of the bibigrid yaml format that makes it difficult to validate; having one list for all configs where the first element of that list has other values than the rest. While a hack has been implemented to allow for intuitive validation via pedantic that produces helpful error messages, simplifying the config should be considered. As this is a change of the configuration that also affects users, this should likely happen in a major version change (related issue #690).
A few inconsistencies between the schema and pedantic have been fixed:
metaandsecurityGroupcloses #688