-
Notifications
You must be signed in to change notification settings - Fork 10
Converting IntroToAnnotationDbi.Rnw to Rmarkdown #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
AFAIK there's no automatic way to convert these and I don't think there is an equivalent in R Markdown. It is possible to mock this up in HTML just using R Markdown to make it look similar to the PDF manually then remove the section, like the one above, since it would no longer be used. |
You can create a <details> Solution <summary> Here is the solution </summary>
## R code chunk of the solution
</details> There is also the |
Hello @BerylKanali, I am going to review your PR. We will be using this checklist to review it.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @BerylKanali Thanks for your PR, during the review process I noticed that there are many instances where we need a space between two words please correct the instances like these and let me know I will continue the review process.
Hi @sonali8434 I made the changes, here is the updated HTML file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @BerylKanali Thank you for the changes I have completed the review Please do these modifications after that this PR will be ready for the final review.
I noticed that you have not italicized the objects in many instances please correct that rest everything looks good.
Merge branch 'AnnotationDbi-Rmd' of https://github.com/BerylKanali/AnnotationDbi into AnnotationDbi-Rmd # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
@sonali8434 Thank you for your review, I have made the changes. Here is the updated HTML file. |
Hello, @BerylKanali Thank you so much for the quick edits; just two small changes then it will be ready for @jwokaty. |
Hello @jwokaty, The review of this file is complete. You can do a final review after these two changes are addressed. Thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BerylKanali There are a few more changes. Mostly changes to remove Biocpkg() from things aren't packages. The easiest way to always check is to click on the link of the generated html. There were also 2 package names in the original that weren't correct, preventing the link from being generated properly. We'll be able to merge after these corrections.
The exercise-solution sections look good. Thanks for your work on this!
|
||
- Organism level: e.g. `r Biocpkg("org.Mm.eg.db")`. | ||
- Platform level: e.g. `r Biocpkg("hgu133plus2.db")`, | ||
`r Biocpkg("hgu133plus2.probes")`, `r Biocpkg("hgu133plus2.cdf")` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe these were renamed or misspelled in the original document? Biocpkg can't make links for these, but I did find packages hgu133plus2probe
and hgu133plus2cdf
. Could you update line 37 with these?
|
||
# ChipDb objects and the select method | ||
|
||
An extremely common kind of `r Biocpkg("Annotation")` package is the so called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the writer is speaking generally about Annotation packages but not a specific package named Annotation. Remove
`r Biockpg("")`
(e.g. Entrez Gene id) and contains mappings between this identifier and other | ||
kinds of identifiers (e.g. GenBank or Uniprot accession number, RefSeq id, | ||
etc.). The name of an org package is always of the form org.\<Ab>\.\<id>\.db | ||
(e.g.`r Biocpkg("org.Sc.sgd.db")`where \<Ab>\ is a 2-letter abbreviation of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a closing parenthesis and space between the last backtick and where
so that we have
(e.g.`r Biocpkg("org.Sc.sgd.db")`) where
`r Biocpkg("sgd")` for gene identifiers assigned by the Saccharomyces Genome | ||
Database, or `r Biocpkg("eg")` for Entrez Gene ids). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgd
and eg
are not packages. Remove
`r Biocpkg("")`
kinds of identifiers (e.g. GenBank or Uniprot accession number, RefSeq id, | ||
etc.). The name of an org package is always of the form org.\<Ab>\.\<id>\.db | ||
(e.g.`r Biocpkg("org.Sc.sgd.db")`where \<Ab>\ is a 2-letter abbreviation of the | ||
organism (e.g.`r Biocpkg("Sc")` for *Saccharomyces cerevisiae*) and \<id>\ is an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sc
is not a package. Remove
`r Biocpkg("")`
|
||
# Using select with TxDb packages | ||
|
||
A `r Biocpkg("TxDb")` package (a 'TxDb' package) connects a set of genomic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TxDb
is not a package, but a type of package. Remove
`r Biocpkg("")`
- name: "Marc Carlson" | ||
- name: "Beryl Kanali" | ||
affiliation: "Converted vignette from Sweave to Rmarkdown" | ||
date: "Last modified: November 2022; Compiled: `r format(Sys.time(), '%B %d , %Y')`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Last modified: November 2022; Compiled:
. I don't know where the November 2022 date comes from.
|
||
# Using select with GO.db | ||
|
||
When you load the ` r Biocpkg("GO.db")` package, a *GODb* object is also loaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the space after the first backtick (otherwise it doesn't render the link properly).
@jwokaty
Here is a draft pull request.
The issue is, I need help to figure out what library or a way I can use to automatically section the exercise and solution bit (line 186- 280) like it was done in the Rnw file using the Theorem package:
If not, I can do it manually.
PDF file
HTML file so far
Note: Replaced the dataTypes pdf image file to png for better output.