Add secp256k1-zkp and schnorrsig modules #1
Conversation
jonasnick
force-pushed
the
schnorrsig
branch
2 times, most recently
from
459b005 to
8be2b45
Compare
jonasnick
changed the title
|
un-WIP'ed because rust-secp256k1 0.13 is released |
| } | ||
|
|
||
| trait New { | ||
| fn new<R: Rng>(rng: &mut R) -> SecretKey; |
There was a problem hiding this comment.
I think you want impl Distribution<SecretKey> for Standard rather than this trait.
See the second example in https://docs.rs/rand/0.6.5/rand/distributions/index.html
There was a problem hiding this comment.
I'm getting E0117 ("impl doesn't use types inside crate") because SecretKey isn't defined in this crate. This looks ergonomic but a downside is that copy & pasted code starts diverging from rust-secp.
There was a problem hiding this comment.
Can you PR to rust-secp? Or then do we run into the problem with dev-dependencies features?
There was a problem hiding this comment.
Oh, yes we'd run into that problem.
| .define("USE_NUM_NONE", Some("1")) | ||
| .define("USE_FIELD_INV_BUILTIN", Some("1")) | ||
| .define("USE_SCALAR_INV_BUILTIN", Some("1")) | ||
| .define("USE_ENDOMORPHISM", Some("1")) |
There was a problem hiding this comment.
We should drop this for now because gmax is concerned about patent aggression related to it.
There was a problem hiding this comment.
I just copied it from rust-secp. Is it a concern there also?
There was a problem hiding this comment.
Yes, I thought we'd removed it from rust-secp.
There was a problem hiding this comment.
So this took me way to long to figure out but we can't remove USE_ENDOMORPHISM here without also removing it in rust-secp because the context objects become incompatible.
|
ACK |
|
squashed |
2 participants
WIP because this requires a new rust-secp256k1 release (with rust-bitcoin/rust-secp256k1#105 and rust-bitcoin/rust-secp256k1#101).This PR adds 3 crates, a no_std and low-level
zkp-sys, higher levelzkpand a crate-devfor dev dependencies.