Improve slice eval #446
Draft
Improve slice eval #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary bug fixes for integer slicing for reductions and refactoring slices_eval as suggested in #436.
Had to add a couple of modifications to ensure contiguity of numpy arrays in some special cases where an evaluation (and hence copy, to contiguous memory) did not occur (when not using numexpr and when the expression was simply "o0"). Consequently also had to improve the rebasing of operands which the lazyexpr machinery carries out (prior to this PR, the rebasing would not occur when the lazyexpr was just a blosc2 array, i.e. "a" would not be rebased to "o0").
Before merging have to do a benchmark comparing new slicing with non-unit steps for lazy expressions (which only uses numpy at chunk-level) with the old format (which did stepping for the whole result at once).