-
Notifications
You must be signed in to change notification settings - Fork 309
nix flake: llvm 17 is retired #2590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
@ghuntley is attempting to deploy a commit to the Boundary Team on Vercel. A member of the Team first needs to authorize it. |
🔒 Entelligence AI Vulnerability Scanner ✅ No security vulnerabilities found! Your code passed our comprehensive security analysis. |
"" # Rely on default includes provided by stdenv.cc + libclang | ||
else | ||
"-isystem ${pkgs.llvmPackages_17.libclang.lib}/lib/clang/17/include -isystem ${pkgs.llvmPackages_17.libclang.lib}/include -isystem ${pkgs.glibc.dev}/include"; | ||
"-isystem ${pkgs.llvmPackages.libclang.lib}/lib/clang/${pkgs.llvmPackages.libclang.version}/include -isystem ${pkgs.llvmPackages.libclang.lib}/include -isystem ${pkgs.glibc.dev}/include"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correctness: pkgs.llvmPackages.libclang.version
may not be defined or may not match the actual Clang version directory, causing incorrect include paths and build failures on non-Darwin systems.
🤖 AI Agent Prompt for Cursor/Windsurf
📋 Copy this prompt to your AI coding assistant (Cursor, Windsurf, etc.) to get help fixing this issue
In flake.nix, line 780, the code uses `${pkgs.llvmPackages.libclang.version}` to construct the Clang include path, but this attribute may not exist or may not match the actual Clang version directory, leading to build failures. Replace `${pkgs.llvmPackages.libclang.version}` with `${pkgs.llvmPackages.clang.version}` to ensure the include path matches the installed Clang version.
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
"-isystem ${pkgs.llvmPackages.libclang.lib}/lib/clang/${pkgs.llvmPackages.libclang.version}/include -isystem ${pkgs.llvmPackages.libclang.lib}/include -isystem ${pkgs.glibc.dev}/include"; | |
-isystem ${pkgs.llvmPackages.libclang.lib}/lib/clang/${pkgs.llvmPackages.clang.version}/include -isystem ${pkgs.llvmPackages.libclang.lib}/include -isystem ${pkgs.glibc.dev}/include"; |
Thanks for this! I actually bumped dependencies in flake.nix and dropped the libclang_17 dep myself just a couple days ago. https://github.com/BoundaryML/baml/pull/2577/files I'm curious if you are trying to use nix for your BAML apps? I just use this flake for local development of the BAML project, although I occasionally think about using nix to drive our packaging and deployment, as well as providing the baml-cli via nixpkgs. |
@ghuntley Are you having luck with |
context
Onboarding for folks running NixOS is not smooth. Here's the default experience.
thoughts
notes