Convert v0 RSA PKCS1 sig gen to v1, improve v1 notes schema #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, import the existing v0 schema and vectordata. We'll need to make some changes to better match existing v1 RSA vectors, but for now the only change made is to update the schema name and import the schema/data as it exists in v0.
9 tasks
Use the pre-existing string values as the description field of the note, and then match the bug type to what the other V1 RSA vectors use for the same note key.
In v0 the notes field was only a dictionary of keys to string description values. In v1 this is a dictionary where each key's value is an object that may contain additional metadata (CVEs, references, etc). Each note object has a bugType required property.
Reference the common notes schema from all v1 schemas. Some v1 vectors were sharing a schema with v0, however the notes field structure is not compatible between the two. This worked previously because the schema definition didn't cover the individual note objects. Now that we've tightened the definition, we need to split those shared schemas. Soon we will delete the v0 vectors and associated schema files, so the duplication is temporary.
cpu
changed the title
This was referenced Aug 18, 2025
FiloSottile
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #151
Resolves #89
Additionally, model the "Notes" field of the v1 schema format as part of
schemas/common.json, converting all v1 test vectors to reference the common schema. This captures the textual description from doc/formats.md.