-
Notifications
You must be signed in to change notification settings - Fork 475
fix: dvd regressions #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dvd regressions #1714
Conversation
3db6804
to
2f95822
Compare
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 6300bb7...:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
All tests passing on the master branch were passed completely. Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 6300bb7...:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
All tests passing on the master branch were passed completely. Check the result page for more info. |
@prateekmedia This PR is also ready, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Regressions on DVD files are currently broken. See latest test result. Issue seems to have been caused by a segfault involving a struct that was expected to contain data but was lost in conversion between rust and C.