Fix premature ending error in switch_to_next_file() #1762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 8, 2025 11:42
Fixes CCExtractor#1719 - build was failing with --enable-hardsubx due to missing tesseract library linking. Added pkg_check_modules for tesseract and leptonica in the HARDSUBX section of CMakeLists.txt. Tested with: cmake -DWITH_HARDSUBX=ON -DWITH_OCR=ON -DWITH_FFMPEG=ON
Remove multiprogram check from is_decoder_processed_enough() that caused false 'premature ending' errors in multiprogram mode. The function should return CCX_TRUE when any decoder has processed enough data, regardless of multiprogram setting. Tested with the original failing file - resolves the issue without regression.
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 42d7509...:
Congratulations: Merging this PR would fix the following tests:
All tests passing on the master branch were passed completely. Check the result page for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1701
Problem:
The is_decoder_processed_enough() function always returned 'CCX_FALSE' in multiprogram mode due to an unnecessary 'ctx->multiprogram == CCX_FALSE' check. This caused false "premature ending" errors in
switch_to_next_file().Solution:
Remove the multiprogram check from
is_decoder_processed_enough(). The function should returnCCX_TRUEwhen any decoder has processed enough data, regardless of multiprogram setting.Testing: