fix: prevent infinite loop when processing TS files with no subtitles #1763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When processing TS files containing no subtitles, ccextractor enters an infinite loop and floods the terminal with binary output instead of exiting gracefully (Issue #1754).
Root Cause:
The
ts_readstreamfunction ints_functions.chad ado-while (!gotpes)loop that would run indefinitely when no subtitle streams were detected, becausegotpesnever became true in files without subtitles.Solution:
subtitle_foundflag that gets set when actual caption data is processedChanges Made:
src/lib_ccx/ts_functions.c: Added termination condition ints_readstreamfunctionTesting
Fixes #1754