[FIX] Handle double-hyphens in XML comments in spupng encoder #1783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfsmp3
changed the title
7 tasks
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 60ae6fb...:
Your PR breaks these cases:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit da03c1e...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
x15sr71
pushed a commit
to x15sr71/ccextractor
that referenced
this pull request
Dec 9, 2025
…CExtractor#1783) Original description: Pull Requests Description : Added logic to detect and replace any occurrence of "--" in comments with a single "-" to ensure valid XML. Used a bulk write ('fwrite') to efficiently handle portions of the string that don't contain invalid sequences. Ensured that comments are written correctly without altering the original structure of the code. Updated function 'write_spucomment' to handle the sanitization process efficiently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
write_spucommentto handle double-hyphens (--) which are invalid inside XML comments--sequences to produce valid XML outputSupersedes #1642
Test plan
--🤖 Generated with Claude Code