-
Notifications
You must be signed in to change notification settings - Fork 12
[7주차] Team 이어드림 김영서 & 이주희 미션 제출합니다. #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kkys00
wants to merge
48
commits into
CEOS-Developers:master
Choose a base branch
from
VoteDream:main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
3848bdf
chore: 기본 세팅
kkys00 28b8af0
Merge pull request #1 from kkys00/develop
kkys00 1d1d553
chore: 디자인 시스템 세팅
kkys00 41e1a81
Merge pull request #2 from kkys00/develop
kkys00 3299cdf
feat: 공통 컴포넌트 submit btn 추가
kkys00 bb36a5d
feat: auth 페이지 header, input 컴포넌트
kkys00 f842ee5
style: 테마 색상 수정
kkys00 0d72138
feat: 로그인, 회원가입 페이지 input UI 추가
kkys00 6a431b3
feat: 팀/팀원 선택 추가
kkys00 f3a7651
style: layout 조정
kkys00 d3d3bcd
feat: 투표 페이지
BeanMouse 74019b2
feat: 결과 페이지
BeanMouse b552edb
feat: 데모데이 투표
BeanMouse c4a8a21
chore: 레이아웃 이름 변경
kkys00 84fd3e6
feat: lottie 컴포넌트 추가
kkys00 eba8801
feat: 홈페이지
kkys00 67147c5
Merge pull request #3 from kkys00/feature/sign
kkys00 93d6cb4
Merge pull request #4 from VoteDream/feature/votes
kkys00 f981a01
Merge pull request #5 from kkys00/feature/home
kkys00 f463a20
feat: 홈페이지 반응형 추가
kkys00 18e1e9e
feat: 로그인, 회원가입 페이지 반응형 추가
kkys00 bb8d7c3
style: lottie 크기 수정
kkys00 b985cf9
chore: 반응형 적용
BeanMouse b9b3b4a
feat: 홈 로그인 회원가입 반응형 추가
BeanMouse 2ef3575
Merge pull request #7 from VoteDream/feature/votes
kkys00 1fbcee5
refactor: 백엔드 enum type 반영
kkys00 416249b
feat: tanstack query 추가
kkys00 476c5fa
feat: 회원가입 api 연결
kkys00 775cde7
feat: 로그인 api 연결 구현
kkys00 461cf14
chore: 주석, 파일 정리
kkys00 1186d18
feat: 회원가입 유효성 검사 추가
kkys00 7ed314b
docs: readme 작성
kkys00 de1cc9c
Merge pull request #8 from kkys00/feature/api
kkys00 84d7980
Merge pull request #9 from kkys00/docs/README
kkys00 e471545
Merge pull request #10 from VoteDream/develop
kkys00 fa65a42
refactor: enum -> as const로 변경
kkys00 9b5a7bc
refactor: inputField 컴포넌트 삭제
kkys00 10b3c5e
feat: 유저 정보 저장
kkys00 64127ed
Refactor: 로그인 유저 정보 저장
BeanMouse bba21af
feat: api 연결 로직
BeanMouse 5cedc17
feat: api 연결
BeanMouse 22b1344
feat: 정보 추가
BeanMouse 717eaf6
feat: 정보 추가 및 팀 한영 변환
BeanMouse 56a0b4d
Merge pull request #12 from VoteDream/feature/voteApi
kkys00 00df2e0
Refactor: 팀명 오류 수정, 투표 상태 반영 구현 (#13)
kkys00 a1d9abf
Fix: 로컬 스토리지 에러 수정 (#14)
kkys00 4b88f2a
Docs: readme 작성 (#15)
kkys00 39a8e99
Merge pull request #16 from VoteDream/develop
kkys00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| name: Feature | ||
| about: new feature | ||
| title: "Feature:" | ||
| labels: feature | ||
| assignees: "" | ||
| --- | ||
|
|
||
| 설명을 작성해주세요. | ||
|
|
||
| ## To Do | ||
|
|
||
| - [ ] todo | ||
| - [ ] todo | ||
|
|
||
| ## ETC | ||
|
|
||
| 기타사항을 작성해주세요. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| name: Fix | ||
| about: 트러블 슈팅 | ||
| title: 'Fix:' | ||
| labels: '' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| ## Description | ||
| 설명을 작성해주세요. | ||
|
|
||
| ## ETC | ||
| 기타사항을 작성해주세요. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| name: HotFix | ||
| about: 치명적인 버그 | ||
| title: "Hotfix:" | ||
| labels: "" | ||
| assignees: "" | ||
| --- | ||
|
|
||
| ## Description | ||
|
|
||
| 설명을 작성해주세요! | ||
|
|
||
| ## ETC | ||
|
|
||
| 기타사항을 작성해주세요. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| name: Refactoring | ||
| about: 리팩토링 | ||
| title: 'Refactoring:' | ||
| labels: refactor | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| ## Description | ||
| 리팩토링 배경을 설명해주세요. | ||
|
|
||
| ## AS-IS | ||
| 기존에 구현되어있는 방식을 설명해주세요. | ||
|
|
||
| ## TO-BE | ||
| 어떻게 리팩토링 되어야하는 지 설명해주세요. | ||
|
|
||
| ## ETC | ||
| 기타사항을 작성해주세요. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| name: Style | ||
| about: 디자인 요소 변경 | ||
| title: "Style:" | ||
| labels: style | ||
| assignees: "" | ||
| --- | ||
|
|
||
| ## Description | ||
|
|
||
| 설명을 작성해주세요! | ||
|
|
||
| ## To Do | ||
|
|
||
| - [ ] todo | ||
| - [ ] todo | ||
|
|
||
| ## ETC | ||
|
|
||
| 기타사항을 작성해주세요. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| ## PR 제목 | ||
|
|
||
| ### PR을 한 이유 🎯 | ||
|
|
||
| - (이곳에 PR을 작성한 이유를 간략하게 적어주세요.) | ||
|
|
||
| ### 이슈 번호 📎 | ||
|
|
||
| - (해결하고자 하는 이슈의 이름과 해시태그 번호를 적어주세요. 예: `이슈명 #123`) | ||
|
|
||
| ### 변경사항 🛠 | ||
|
|
||
| - (개발한 내용의 요약을 적어주세요. 예: "로그인 버그 수정", "새로운 기능 추가" 등) | ||
|
|
||
| ### 특이사항 📌 | ||
|
|
||
| - (이 PR에 대한 추가적인 정보나, 리뷰어가 주의깊게 봐야할 점 등을 적어주세요.) | ||
|
|
||
| ### 테스트 결과 📝 | ||
|
|
||
| - (테스트를 진행한 결과, 해당 결과에 따른 스크린샷 또는 기타 정보를 제공해주세요.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: ESLint Check | ||
|
|
||
| # Pull Request가 실행될 때만 실행 | ||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - develop | ||
|
|
||
| jobs: | ||
| lint: | ||
| name: Run ESLint | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| # 1. 코드 체크아웃 -> 코드를 가져오기 위해 필요 | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| # 2. Node.js 설정 -> js파일 린트를 위해 필요 | ||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 | ||
|
|
||
| # 3. 의존성 설치 -> ESlint 실행 필요 | ||
| - name: Install dependencies | ||
| run: npm install | ||
|
|
||
| # 4. ESLint 실행 -> 린트 실행! | ||
| - name: Run ESLint | ||
| run: npm run lint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| /.pnp | ||
| .pnp.* | ||
| .yarn/* | ||
| !.yarn/patches | ||
| !.yarn/plugins | ||
| !.yarn/releases | ||
| !.yarn/versions | ||
|
|
||
| # testing | ||
| /coverage | ||
|
|
||
| # next.js | ||
| /.next/ | ||
| /out/ | ||
|
|
||
| # production | ||
| /build | ||
|
|
||
| # misc | ||
| .DS_Store | ||
| *.pem | ||
|
|
||
| # debug | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| .pnpm-debug.log* | ||
|
|
||
| # env files (can opt-in for committing if needed) | ||
| .env* | ||
|
|
||
| # vercel | ||
| .vercel | ||
|
|
||
| # typescript | ||
| *.tsbuildinfo | ||
| next-env.d.ts | ||
|
|
||
| .vercel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| npx --no-install commitlint --edit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| npm run lint | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "plugins": ["prettier-plugin-tailwindcss"] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting을 돌려서 코드의 품질을 체크한 뒤, 커밋을 할 수 있도록 husky를 쓰는 태도 정말 훌륭합니다