[22기_이수아] 동시성 & 결제 연동 미션 제출합니다. #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danaggero
reviewed
Oct 27, 2025
| } | ||
|
|
||
| //==생성 메서드=// | ||
| public static OrderEntity createOrder(Long memberId, Long cinemaId, OrderFoodEntity... items) { |
| .orElseThrow(null); | ||
| return Cinema.from(cinema); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
읽기 전용 클래스를 분리하셨네요! 확장성과 책임분리 측면에서 좋은 설계인 것 같습니다!
There was a problem hiding this comment.
Reader 클래스에는 트랜잭션 ReadOnly를 true로 설정해야 할까요?
There was a problem hiding this comment.
saver, reader로 분리할 생각을 못했네요. 제가 아직 책임분리 코드 작성을 못했는데 참고해보겠습니다!
| @Transactional(readOnly = true) | ||
| public class FavoriteCinemaService { | ||
|
|
||
| private FavoriteCinemaReader favoriteCinemaReader; |
| favoriteMovieRepository.delete(new FavoriteMovieEntity(memberId, movieId)); | ||
| } | ||
|
|
||
| } No newline at end of file |
junilyy
reviewed
Oct 27, 2025
Comment on lines
+7
to
+13
| @Target({ElementType.FIELD}) | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Documented | ||
| @Component | ||
| public @interface ExplainError { | ||
| String value() default ""; | ||
| } |
There was a problem hiding this comment.
어노테이션을 직접 정의하신건가요? 혹시 어디에 이용되는지 알 수 있을까요
Comment on lines
+20
to
21
| CinemaEntity cinemaEntity = cinemaRepository.findById(id) | ||
| .orElseThrow(() -> new IllegalArgumentException("영화관을 찾을 수 없습니다. id=" + id)); |
There was a problem hiding this comment.
얘만 IllegalArgumentException로 따로 처리하는 이유가 있나요??
| .orElseThrow(null); | ||
| return Cinema.from(cinema); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
saver, reader로 분리할 생각을 못했네요. 제가 아직 책임분리 코드 작성을 못했는데 참고해보겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
시험 + 책임 분리 단계에서 뜯어고칠 코드 많음 이슈로 과제 진행도가 미흡합니다...
최대한 스터디 전까지 완료하겠습니다..!