Skip to content

feat: export protobuf #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdacoello merged 25 commits into from
Dec 3, 2025
Merged

feat: export protobuf #144

jdacoello merged 25 commits into from
Dec 3, 2025

Conversation

@ahmdmhd
Copy link
Collaborator

@ahmdmhd ahmdmhd commented Oct 24, 2025 •
edited
Loading

This PR implements support for exporting .proto files.

s2dm export protobuf --schema /path/to/schema --output output.proto --selection-query /path/to/selection/query [--package-name package.name] [--flatten-naming]

Based on #146.

@ahmdmhd ahmdmhd changed the title feat: export protobuf [WIP] feat: export protobuf Oct 24, 2025
@jdacoello jdacoello deleted the branch COVESA:main October 27, 2025 09:36
@jdacoello jdacoello closed this Oct 27, 2025
@jdacoello jdacoello reopened this Oct 27, 2025
@jdacoello
Copy link
Collaborator

jdacoello commented Oct 27, 2025

There is a mismatch in the develop commit history. The develop branch will be deleted.
@ahmdmhd , please rebase your branch and direct the PR against the main branch directly.

@ahmdmhd ahmdmhd force-pushed the feat/export-protobuf branch from 2a99ade to f4b2f1a Compare October 27, 2025 15:00
@ahmdmhd ahmdmhd changed the base branch from develop to main October 27, 2025 15:01
@ahmdmhd ahmdmhd force-pushed the feat/export-protobuf branch from 36edab9 to c8f265f Compare October 30, 2025 13:55
@ahmdmhd ahmdmhd changed the title [WIP] feat: export protobuf feat: export protobuf Oct 30, 2025
@ahmdmhd ahmdmhd marked this pull request as ready for review October 30, 2025 13:55
ahmdmhd added 15 commits November 5, 2025 16:07
@ahmdmhd
feat(cli): implement selection query support in export commands
331110c 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
feat(protobuf): implement protobuf exporter
03ea0c8 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
fix(protobuf): wrap enums in messages
5a76494 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
feat(protobuf): add source option
6fa94a7 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
feat(protobuf): add protovalidate support
7731b65 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
test(protobuf): add tests
8494831 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
feat(protobuf): implement instance expansion
ecb959e 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
docs(protobuf): document exporter functionality
344cb1e 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
feat(protobuf): include .proto imports only if they are required
7663283 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
fix(protobuf): include union types in flattened mode
39ab849 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
fix(protobuf): include all referenced types in the output
92f3665 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
docs(protobuf): add section on field number stability and its implica…
0cf37c6 
…tions

Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
feat(protobuf): support field nullability
23147b9 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
feat(cli): make --selection-query required for protobuf
c338f12 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd
feat(protobuf): flatten all root-level types from selection query
f8da8b8 
Signed-off-by: Ahmed Mohamed <[email protected]>
@ahmdmhd ahmdmhd force-pushed the feat/export-protobuf branch from 1efd74b to f8da8b8 Compare November 5, 2025 15:09
@ahmdmhd
Copy link
Collaborator Author

ahmdmhd commented Nov 5, 2025 •
edited
Loading

@jdacoello the PR is now ready to be reviewed.

The following has been changed:

  • The --selection-query​ flag is now mandatory.
  • Name flattening now works for types present in the selection query.
  • Nullable fields are mapped to optional and non-null fields include validation.
  • A bug that prevented referenced types from being included in the proto file is now fixed.
  • The documentation includes a comment on field numbering in proto files.

@ahmdmhd ahmdmhd mentioned this pull request Nov 12, 2025
Merged
jdacoello
jdacoello requested changes Nov 20, 2025
View reviewed changes
@ahmdmhd ahmdmhd force-pushed the feat/export-protobuf branch from 15952b8 to b258fd4 Compare November 27, 2025 13:17
@jdacoello jdacoello self-requested a review December 3, 2025 10:12
@jdacoello jdacoello merged commit 4996df8 into COVESA:main Dec 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdacoello jdacoello jdacoello approved these changes

@sschleemilch sschleemilch Awaiting requested review from sschleemilch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmdmhd @jdacoello