LIST namespace #234
Draft
LIST namespace #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusfavarin
requested changes
Oct 1, 2025
rewrite/src/exe/list.c
Outdated
|
|
||
| void LIST_AddFront(LinkedList* list, Item* item) | ||
| { | ||
| if (item == NULL) |
There was a problem hiding this comment.
for short one line if statements, just do if (cond) { action(); }
include/ctr/list.h
Outdated
| Item* LIST_RemoveMember(LinkedList* L, Item* I); | ||
| Item* LIST_RemoveFront(LinkedList* L); | ||
| Item* LIST_RemoveBack(LinkedList* L); | ||
| void LIST_Init(LinkedList* L, Item* item, int itemSize, int numItems); No newline at end of file |
There was a problem hiding this comment.
Should we set itemSize as unsigned? Also, try using const Type* every time the function doesn't modify the contents that the variable is pointing to
There was a problem hiding this comment.
I was planning on looking closer at the asm to figure out the signs (I imagine it's fine to make it unsigned, but I wanted to check)
rewrite/src/exe/list.c
Outdated
|
|
||
| void LIST_Init(LinkedList* list, Item* item, int itemSize, int numItems) | ||
| { | ||
| while (numItems > 0) |
There was a problem hiding this comment.
prefer doing for loops over while loops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, need to adjust coll to work with new backup system still.