This repository was archived by the owner on Jun 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 71
iOS 13 compatibility #26
Open
adrianso
wants to merge
9
commits into
Calvin-Huang:master
Choose a base branch
from
adrianso:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Will this ever be merged? @Calvin-Huang |
Fixed the following build warning: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'. It will be removed soon.
|
In hopes of making this easier for others to track down, we started getting crash reports similar to this: We were able to resolve the issue by switching to this PR: // package.json
"react-native-device-brightness": "Calvin-Huang/react-native-device-brightness#26/head",Given the introduction of autolinking and the iOS 13 issue, it would be nice if this could be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set brightness level in main thread.