Skip to content

Conversation

@khaledelnaggar
Copy link
Contributor

Please enter a short description of your pull request and add a reference to the Jira ticket.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Copy link
Contributor

@reichli reichli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Please also remove the corresponding code behind those UI elements (event handlers, dialogs, etc.) if they are not used anywhere else.

@sonarqubecloud
Copy link

@khaledelnaggar khaledelnaggar requested a review from reichli April 2, 2025 17:07
@khaledelnaggar khaledelnaggar changed the title Hiding Upload Project option in main menu and project options IDE-285 IDE-285 Hiding Upload Project option in main menu and project options Apr 26, 2025
@juliajulie95 juliajulie95 self-assigned this May 2, 2025
@juliajulie95
Copy link
Contributor

Please check especially these failing tests:
CatblocksScriptFragmentTest.testContextMenuItems
ScriptSplitUserDefinedBrickTest.testSplitUserDefinedBrick
ImportObjectIntoProjectTest.importProjectWithoutConflictsTestEqualLocalVariable
ChangeVariableTest.testViewInFormulaEditorAfterClone
DeleteLookBrickTest.testPaintAndDeleteLook
DeleteLookBrickTest.testPaintLookWithoutDelete
WhenBackgroundChangesToBrickTest.testCreateNewBackground
FormulaEditorKeyboardTest.testConfirmButtonString
ProjectActivityTest.testLastUsedProjectPreference
CreateProjectTest.testCastOptionNotShowed
UserDefinedBrickTest.testEditFormulaInUserDefinedBrickWithInput
FormulaEditorFragmentActivityRecreateRegressionTest.testActivityRecreateStringDialogFragment

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants