Skip to content

Conversation

@moe-threeface
Copy link
Contributor

@moe-threeface moe-threeface commented Apr 9, 2025

Testing "go to touch" in: simple single way, out of bound and returning in bound multiple random touches.

https://catrobat.atlassian.net/browse/CATROID-1619

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@moe-threeface moe-threeface changed the title finished go to touch function test Catroid-1619 add go to touch function test Apr 23, 2025
@moe-threeface moe-threeface force-pushed the CATROID-1619 branch 2 times, most recently from 9e893dc to a1a2340 Compare April 23, 2025 16:20
@moe-threeface moe-threeface changed the title Catroid-1619 add go to touch function test CATROID-1619 add go to touch test function Apr 23, 2025
Copy link
Contributor

@reichli reichli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
The Go to touch position-Test can be improved, the rest looks good :)
Please also put some assertions on the y-coordinate and another one verifying that the object is actually rendered at the position (color sensors will do the trick).

@reichli reichli self-assigned this May 2, 2025
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants