Google2D & Azure2D ImageryProvider classes

[lukemckinstry]

Description

There will be multiple ways to add Google2D data - explained in docs

• IonImageryProvider.fromAssetId
  • Works exactly the same as all other assets hosted in ion. ion will have 5 Google Maps assets.
• Google2DImageryProvider.fromIonAssetId
  • similar to IonImageyProvider.fromAssetId, but user can add params to create custom maps and overlays beyond the 5 available in ion. Data still streams via ion.
• Google2DImageryProvider.fromUrl
  • For users who opt not to stream via ion, sets up session and steams tiles directly from Google api
• Google2DImageryProvider constructor -
  • docs have note This object is normally not instantiated directly, use Google2DImageryProvider.fromIon or Google2DImageryProvider.fromUrl.

ToDo

DO NOT MERGE until complete

• Will 2D Azure go out
  • If no. set class to private, pull sandcastle??,
• Prod asset IDs
• BaseLayerPicker in viewer, which layers to include? (also need to make thumbnails)
• one-time check for google geocoder? Google2D & Azure2D ImageryProvider classes #12913 (comment)
• logo attribution https://github.com/iTwin/curated-data/issues/634#issuecomment-3343464031
• sandcastle thumbnails - waiting for logo attribution, so that thumbnails have logos visible

Issue number and link

Testing plan

Sandcastles (to publish in prod)

To view the sandcastles, add the key to your Ion Staging account.

• Add Google 2D Data ci-build link
• Add Azure 2D Data ci-build link
• Add Google 2D Data with custom styles ci-build link
• Imagery Assets available in ion ci-build link

Test all ways to add Google 2D data

• IonImageryProvider.fromAssetId() - sandcastle 1&2
• Google2DImageryProvider.fromIonAssetId (with and params to create maps, overlays and custom styles on a roadmap)- sandcastle 3
• Google2DImageryProvider.fromUrl
  • In sandcastles replace Google2DImageryPrivider fromIon with fromUrl
  • add Google api key

Cesium.Google2DImageryProvider.fromUrl({
  key: apiKey,
  mapType: "terrain",
}),

• test token refresh

//add to bottom of sandcastle using IonImageryProvider.fromAssetId
setTimeout(() => {
  google._imageryProvider._imageryProvider._imageryProvider._resource.setQueryParameters({key: "invalid-key"})
},3000)

//add to bottom of sandcastle using Google2DImageryProvider.fromIon
setTimeout(() => {
  google._imageryProvider._imageryProvider._resource.setQueryParameters({key: "derp"})
},3000)

• Check attribution - satellite map has most attribution

Author checklist

• I have submitted a Contributor License Agreement
• I have added my name to CONTRIBUTORS.md
• I have updated CHANGES.md with a short summary of my change
• I have added or updated unit tests to ensure consistent code coverage
• I have updated the inline documentation, and included code examples where relevant
• I have performed a self-review of my code

[github-actions]

Thank you for the pull request, @lukemckinstry!

✅ We can confirm we have a CLA on file for you.

[ggetz]

Looking good on an initial pass @lukemckinstry! Just a few comments to consider as you continue to add updates.

[lukemckinstry]

@ggetz thanks for the PR feedback. I addressed all the comments from the latest review.

[ggetz]

@lukemckinstry Pushed up a fix/refactor to how we're handling IonResources and credits, as discussed. Please let me know if there are any questions.

[ggetz]

Looks like changing the attribution list on the fly is causing problems for our credits popup.

Ah, that's no good. However, and correct me if I'm mistaken, this issue is not unique to the Google imagery provider–which is now using the more standard method of attribution.

Non-ideal for sure, but I don't think it need to hold up this PR. @lukemckinstry Could you open a new issue for the data attribution popup, assuming there is not already one open?