-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add declusteredEvent to EntityCluster #12920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Oko-Tester
wants to merge
9
commits into
CesiumGS:main
Choose a base branch
from
Oko-Tester:fix-issue-5760-declustered-entities
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add declusteredEvent to EntityCluster #12920
Oko-Tester
wants to merge
9
commits into
CesiumGS:main
from
Oko-Tester:fix-issue-5760-declustered-entities
+342
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for the pull request, @Oko-Tester! ✅ We can confirm we have a CLA on file for you. |
javagl
reviewed
Sep 25, 2025
746701c
to
2d42fdc
Compare
this is ready |
mzschwartz5
reviewed
Sep 26, 2025
mzschwartz5
reviewed
Sep 26, 2025
Fixes CesiumGS#5760 by adding declusteredEvent that provides both clustered and declustered entities, plus new API methods for accessing clustering state. Maintains backward compatibility.
… skipping unused declustering computations
9bd82e9
to
587e235
Compare
@mzschwartz5 Is there any news regarding the approval? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5760 by adding declusteredEvent that provides both clustered and declustered entities, plus new API methods for accessing clustering state. Maintains backward compatibility.
Description
This PR adds comprehensive clustering state information to EntityCluster by introducing a new
declusteredEvent
and supporting API methods. The originalclusterEvent
only provided information about entities that were successfully clustered, but developers also needed access to entities that were processed but not clustered (declustered entities).Key Changes
declusteredEvent
: Fires with complete clustering information including both clustered and declustered entitiesgetLastClusteredEntities()
- Returns currently clustered entitiesgetLastDeclusteredEntities()
- Returns currently declustered entitiesgetAllProcessedEntities()
- Returns all entities processed during clusteringclusterEvent
remains unchanged and functionalIssue number and link
Fixes #5760 - Include declustered entities in cluster callback
This addresses multiple user requests from the forum and GitHub comments spanning several years.
Testing plan
Manual Testing
declusteredEvent
fires with correctclustered
anddeclustered
arraysclusterEvent
still works as beforeAuthor checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change