Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/prod.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: prod
on:
on:
push:
branches:
- 'cesium.com'
branches:
- "cesium.com"
jobs:
lint:
runs-on: ubuntu-latest
Expand All @@ -11,7 +11,7 @@ jobs:
- name: install node 22
uses: actions/setup-node@v5
with:
node-version: '22'
node-version: "22"
- name: npm install
run: npm install
- name: lint *.js
Expand All @@ -36,13 +36,17 @@ jobs:
- name: install node 22
uses: actions/setup-node@v5
with:
node-version: '22'
node-version: "22"
- name: npm install
run: npm install
- name: build website release
run: npm run website-release
- name: build apps
run: npm run build-apps
- name: build types
run: npm run build-ts
- name: build prod sandcastle
run: npm run build-prod -w packages/sandcastle -- -l warn
- name: deploy to cesium.com
if: ${{ env.AWS_ACCESS_KEY_ID != '' }}
run: |
Expand All @@ -51,4 +55,4 @@ jobs:
aws s3 sync Build/release/ s3://cesium-website/cesiumjs/releases/$(cat package.json | jq -r '.version' | sed 's/\.0$//')/ --cache-control "public, max-age=1800" --delete
aws s3 sync Build/Documentation/ s3://cesium-website/cesiumjs/ref-doc/ --cache-control "public, max-age=1800" --delete
aws s3 sync Build/CesiumViewer/ s3://cesium-website/cesiumjs/cesium-viewer/ --cache-control "public, max-age=1800" --delete
aws s3 sync Build/Sandcastle/ s3://cesium-sandcastle-website/ --cache-control "public, max-age=1800" --delete
aws s3 sync Build/Sandcastle2/ s3://cesium-sandcastle-website/ --cache-control "public, max-age=1800" --delete
2 changes: 1 addition & 1 deletion Apps/Sandcastle/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
data-dojo-type="dijit.layout.ContentPane"
data-dojo-props="region: 'top'"
>
<a href="https://dev-sandcastle.cesium.com"
<a href="https://sandcastle.cesium.com"
>Try the new version of Sandcastle today!</a
>
</div>
Expand Down
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## 1.134 - 2025-10-01

- [Sandcastle](https://sandcastle.cesium.com/) has been updated at `https://sandcastle.cesium.com`! The [legacy Sandcastle app](https://cesium.com/downloads/cesiumjs/releases/1.134/Apps/Sandcastle/index.html) will remain available through November 3, 2025.

### @cesium/engine

#### Fixes :wrench:
Expand Down
8 changes: 8 additions & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,13 @@ export const websiteRelease = gulp.series(
node: false,
});
},
function () {
return buildCesium({
minify: true,
removePragmas: true,
node: false,
});
},
combineForSandcastle,
buildDocs,
);
Expand Down Expand Up @@ -663,6 +670,7 @@ export const makeZip = gulp.series(release, async function createZipFile() {
"!**/*.gitignore",
"!Specs/e2e/*-snapshots/**",
"!Apps/Sandcastle/gallery/development/**",
"!Apps/Sandcastle2/**",
],
{
encoding: false,
Expand Down
5 changes: 2 additions & 3 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,11 @@
<a href="Apps/HelloWorld.html">Hello World</a>
</li>
<li>
<a href="Apps/Sandcastle/index.html">Sandcastle</a>
<a href="Apps/Sandcastle2/index.html">Sandcastle</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should build-sandcastle become part of the build step? Either the build itself, or as part of the initial run on npm start?

It was a bit confusing when I ran:

npm install
npm run make-zip
npm start

but when I clicked on Sandcastle, I still saw

Image

This fix could be a fast follow PR, as it does not impact the release itself.

<ul>
<li>
<a href="Build/Apps/Sandcastle/index.html">Built Sandcastle</a>
<a href="Apps/Sandcastle/index.html">Legacy Sandcastle</a>
</li>
<li><a href="Apps/Sandcastle2/index.html">Sandcastle v2</a></li>
</ul>
</li>
<li>
Expand Down
4 changes: 3 additions & 1 deletion packages/sandcastle/sandcastle.config.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import process from "process";

const config = {
root: ".",
sourceUrl: "https://github.com/CesiumGS/cesium/blob/main/packages/sandcastle",
Expand All @@ -19,7 +21,7 @@ const config = {
labels: [],
development: false,
},
includeDevelopment: true,
includeDevelopment: !process.env.PROD,
},
};

Expand Down
5 changes: 4 additions & 1 deletion packages/sandcastle/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,10 @@ function App() {
synchronizeColorScheme
>
<div className="banner">
<Anchor href="https://sandcastle.cesium.com" tone="accent">
<Anchor
href="https://cesium.com/downloads/cesiumjs/releases/1.134/Apps/Sandcastle/index.html"
tone="accent"
>
Comment on lines +486 to +489
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind opening an standalone issue for the plan to fully remove the old Sandcastle? I think it'll be helpful to discuss apart from the "new" Sandcastle plans themselves.

Looking for the old Sandcastle? It's still here (for a little while) →
</Anchor>
</div>
Expand Down
8 changes: 3 additions & 5 deletions packages/sandcastle/src/Gallery/Gallery.css
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,9 @@
padding: var(--stratakit-space-x2);
gap: var(--stratakit-space-x2);
overflow-y: auto;
&:focus-visible {
/* small margin to allow focus highlight to be visible all the way around */
margin: 0 3px 4px;
border-radius: var(--stratakit-ext-radius-xs);
}
/* small margin to allow focus highlight to be visible all the way around */
margin: 0 3px 4px;
border-radius: var(--stratakit-ext-radius-xs);
}

.empty-list div {
Expand Down