-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Sandcastle full release #12937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Sandcastle full release #12937
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c1a14d8
change banner links
jjspace 3fda5a0
update gallery focus outline style
jjspace 3a0a7a4
update local server links to new sandcastle
jjspace 75e1e34
don't include dev sandcastles in prod
jjspace 8e75bfc
revert release sandcastle link
jjspace 8aab6df
deploy new sandcastle in prod
jjspace 28719ef
exclude gallery from the zip
jjspace cbb0883
backport extra build during website-release from cesium.com branch
jjspace 978056c
Merge remote-tracking branch 'origin/main' into sandcastle-banner-update
jjspace 74c943d
Update CHANGES.md
ggetz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -483,7 +483,10 @@ function App() { | |
synchronizeColorScheme | ||
> | ||
<div className="banner"> | ||
<Anchor href="https://sandcastle.cesium.com" tone="accent"> | ||
<Anchor | ||
href="https://cesium.com/downloads/cesiumjs/releases/1.134/Apps/Sandcastle/index.html" | ||
tone="accent" | ||
> | ||
Comment on lines
+486
to
+489
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would you mind opening an standalone issue for the plan to fully remove the old Sandcastle? I think it'll be helpful to discuss apart from the "new" Sandcastle plans themselves. |
||
Looking for the old Sandcastle? It's still here (for a little while) → | ||
</Anchor> | ||
</div> | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
build-sandcastle
become part of the build step? Either the build itself, or as part of the initial run onnpm start
?It was a bit confusing when I ran:
but when I clicked on Sandcastle, I still saw
This fix could be a fast follow PR, as it does not impact the release itself.