-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add share button #2057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add share button #2057
Conversation
Hi @willydouhard, I started working on this idea of a sharing thread feature, but I'd love to get your guidance. I know you've been considering this feature for a while. I'm curious if you've already thought of the best way to handle this backend-wise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution, it looks great! I added a few comments
return | ||
|
||
new_thread_id = str(uuid.uuid4()) | ||
init_http_context(thread_id=new_thread_id, user=user) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think we need this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot make it work without actually. I may be missing something
hello! I was in offline, but I'm taking this back this week |
Excited about this! Internally, we've implemented a basic approach for sharing threads using a |
Thanks for the feedback @sanchezedgar , I believe we could, yes, I like the header Idea. Let me start by tackling the first blocking points for the PR and we can work on this as well |
Thanks for the PR! I have a couple of questions:
|
@willydouhard I wonder if it doesn't raise more complexity actually, since one user could share a thread using a specific profile and the end user loading this shared thread might not have permissions for that profile. I imagine this could lead to unexpected failures |
Hi, thanks for your PR ❤️ Really looking forward to this feature! |
@celeriev thanks for the work on this much needed PR. Is this good to go from your perspective? If so please mark it ready for review. |
This PR is stale because it has been open for 14 days with no activity. |
@celeriev if you're up for it I think we're ready for this. This is a highly desirable feature and you e done a great job with it. Do you plan on finishing this? |
hello @hayescode , unfortunately, I believe it is not yet fully tested, but I would welcome anyone to take it from there. My main concern would be the way this feature would act with active chat profiles, in case the receiver of the shared thread doesn't have access to the chat profile used by the user owning the shared thread. |
Latest change:
Screen.Recording.2025-05-12.at.13.42.55.mov
History:
3ff1de9
Screen.Recording.Mar.25.2025.mov