feat: server setup + refactor #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting custom Eval in cli.js
|
|
||
| ## Project Structure | ||
|
|
||
| This project is a normal NodeJS project with a target of using as less NPM dependencies as much possible. |
There was a problem hiding this comment.
May not be the goal here. Building the fastest JS implementation is.
| - [`./server.js`](./server.js) - This file setsup a server to accept connections and respond to requests from client. This is the file where the Raft Node is instantiated and connected to the other nodes in the cluster. | ||
|
|
||
| ## How to Contribute? | ||
| - Refer to issue tickets on [Github](https://github.com/techsavvyash/stylusdb-js) |
raft/index.js
Outdated
| // RPC command | ||
| case 'rpc': | ||
| //TODO Check this make sure that it is called through the leader of | ||
| console.log("RAHUL in command case :", raft.leader === this.address) |
There was a problem hiding this comment.
Let's also convert all console logs to proper logging. Pino is a good alternative.
|
|
||
| raft.change({ term: 139 }); | ||
| raft.emit('data', { | ||
| address: 'vladimir', |
reference/index copy.js
Outdated
| var LifeRaft = require('../raft/index'); | ||
| const Log = require('../raft/log'); | ||
|
|
||
| const DBManager = require('../db'); |
There was a problem hiding this comment.
Let's pick one. Leaning towards DBManager. Let's remove LMDBManager altogether.
feat: working set on request to Leader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
Also refer CONTRIBUTING.md